lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Revert D15267963: [quic] Clone RetireConnectionIdFrame

Browse Source 
Differential Revision:
D15267963

Original commit changeset: a2e9059900c0

fbshipit-source-id: c9fb0a514788dd32d5f1956dbea4dcefe34468c8
This commit is contained in:
Shawn Shihang Wei
2019-09-30 18:48:21 -07:00
committed by Facebook Github Bot
parent 59f20c91c7
commit 52a79997d8
2 changed files with 1 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
quic/api/test/QuicTransportTest.cpp
View File

@@ -1510,69 +1510,6 @@ TEST_F(QuicTransportTest, SendRetireConnectionIdFrame) {
EXPECT_TRUE(foundRetireConnectionId); EXPECT_TRUE(foundRetireConnectionId);
} }
TEST_F(QuicTransportTest, CloneRetireConnectionIdFrame) {
auto& conn = transport_->getConnectionState();
// knock every handshake outstanding packets out
conn.outstandingHandshakePacketsCount = 0;
conn.outstandingPureAckPacketsCount = 0;
conn.outstandingPackets.clear();
conn.lossState.initialLossTime.clear();
conn.lossState.handshakeLossTime.clear();
conn.lossState.appDataLossTime.clear();
RetireConnectionIdFrame retireConnId(1);
sendSimpleFrame(conn, retireConnId);
transport_->updateWriteLooper(true);
loopForWrites();
EXPECT_EQ(conn.outstandingPackets.size(), 1);
auto numRetireConnIdPackets = std::count_if(
conn.outstandingPackets.begin(),
conn.outstandingPackets.end(),
[&](auto& p) {
return std::find_if(
p.packet.frames.begin(),
p.packet.frames.end(),
[&](auto& f) {
return folly::variant_match(
f,
[&](QuicSimpleFrame& s) {
return folly::variant_match(
s,
[&](RetireConnectionIdFrame&) { return true; },
[&](auto&) { return false; });
},
[&](auto&) { return false; });
}) != p.packet.frames.end();
});
EXPECT_EQ(numRetireConnIdPackets, 1);
// Force a timeout with no data so that it clones the packet
transport_->lossTimeout().timeoutExpired();
// On PTO, endpoint sends 2 probing packets, thus 1+2=3
EXPECT_EQ(conn.outstandingPackets.size(), 3);
numRetireConnIdPackets = std::count_if(
conn.outstandingPackets.begin(),
conn.outstandingPackets.end(),
[&](auto& p) {
return std::find_if(
p.packet.frames.begin(),
p.packet.frames.end(),
[&](auto& f) {
return folly::variant_match(
f,
[&](QuicSimpleFrame& s) {
return folly::variant_match(
s,
[&](RetireConnectionIdFrame&) { return true; },
[&](auto&) { return false; });
},
[&](auto&) { return false; });
}) != p.packet.frames.end();
});
EXPECT_EQ(numRetireConnIdPackets, 3);
}
TEST_F(QuicTransportTest, NonWritableStreamAPI) { TEST_F(QuicTransportTest, NonWritableStreamAPI) {
auto streamId = transport_->createBidirectionalStream().value(); auto streamId = transport_->createBidirectionalStream().value();
auto buf = buildRandomInputData(20); auto buf = buildRandomInputData(20);

2
quic/state/SimpleFrameFunctions.cpp
View File

@@ -69,7 +69,7 @@ folly::Optional<QuicSimpleFrame> updateSimpleFrameOnPacketClone(
}, },
[&](const RetireConnectionIdFrame&) -> folly::Optional<QuicSimpleFrame> { [&](const RetireConnectionIdFrame&) -> folly::Optional<QuicSimpleFrame> {
// TODO junqiw // TODO junqiw
return QuicSimpleFrame(frame); return folly::none;
}); });
} }