mirror of
https://github.com/facebookincubator/mvfst.git
synced 2025-08-06 22:22:38 +03:00
Translate API closes to Application closes on the wire.
Summary: Previously we would end up writing a non-application close when the application calls close(folly::none). This isn't correct, as those cases should be an application error with no error. Reviewed By: afrind Differential Revision: D20518529 fbshipit-source-id: fe069cccc32bd550fb3ec599694110955816993f
This commit is contained in:
committed by
Facebook GitHub Bot
parent
2f94d3d0e0
commit
42e49bb262
@@ -1243,7 +1243,9 @@ TEST_F(QuicTransportImplTest, RegisterDeliveryCallbackLowerThanExpectedClose) {
|
||||
|
||||
TEST_F(QuicTransportImplTest, TestNotifyPendingConnWriteOnCloseWithoutError) {
|
||||
NiceMock<MockWriteCallback> wcb;
|
||||
EXPECT_CALL(wcb, onConnectionWriteError(IsError(LocalErrorCode::NO_ERROR)));
|
||||
EXPECT_CALL(
|
||||
wcb,
|
||||
onConnectionWriteError(IsError(GenericApplicationErrorCode::NO_ERROR)));
|
||||
transport->notifyPendingWriteOnConnection(&wcb);
|
||||
transport->close(folly::none);
|
||||
evb->loopOnce();
|
||||
@@ -1281,7 +1283,9 @@ TEST_F(QuicTransportImplTest, TestNotifyPendingWriteOnCloseWithoutError) {
|
||||
auto stream = transport->createBidirectionalStream().value();
|
||||
NiceMock<MockWriteCallback> wcb;
|
||||
EXPECT_CALL(
|
||||
wcb, onStreamWriteError(stream, IsError(LocalErrorCode::NO_ERROR)));
|
||||
wcb,
|
||||
onStreamWriteError(
|
||||
stream, IsError(GenericApplicationErrorCode::NO_ERROR)));
|
||||
transport->notifyPendingWriteOnStream(stream, &wcb);
|
||||
transport->close(folly::none);
|
||||
evb->loopOnce();
|
||||
@@ -1369,7 +1373,8 @@ TEST_F(QuicTransportImplTest, TestGracefulCloseWithNoActiveStream) {
|
||||
NiceMock<MockWriteCallback> wcbConn;
|
||||
NiceMock<MockReadCallback> rcb;
|
||||
NiceMock<MockDeliveryCallback> deliveryCb;
|
||||
EXPECT_CALL(rcb, readError(stream, IsError(LocalErrorCode::NO_ERROR)));
|
||||
EXPECT_CALL(
|
||||
rcb, readError(stream, IsError(GenericApplicationErrorCode::NO_ERROR)));
|
||||
EXPECT_CALL(deliveryCb, onDeliveryAck(stream, _, _));
|
||||
|
||||
EXPECT_CALL(connCallback, onConnectionEnd()).Times(0);
|
||||
|
Reference in New Issue
Block a user