lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-25 15:43:13 +03:00
Code Activity

Rename offset in RstStreamFrame to finalSize

Browse Source 
Summary: This will make it easier to distinguish between the `finalSize` and the `reliableSize` when we implement reliable resets

Reviewed By: hanidamlaj

Differential Revision: D64836474

fbshipit-source-id: d811d64a2538d4d1acba1ea10a7790d5905f02a4
This commit is contained in:
Aman Sharma
2024-11-14 11:36:01 -08:00
committed by Facebook GitHub Bot
parent 5b309dba06
commit 3f27fdebd9
10 changed files with 28 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
quic/codec/test/QuicWriteCodecTest.cpp
View File

@@ -2097,7 +2097,7 @@ TEST_F(QuicWriteCodecTest, WriteRstStream) {
auto& resultRstStreamFrame = *regularPacket.frames[0].asRstStreamFrame();
EXPECT_EQ(errorCode, resultRstStreamFrame.errorCode);
EXPECT_EQ(id, resultRstStreamFrame.streamId);
EXPECT_EQ(offset, resultRstStreamFrame.offset);
EXPECT_EQ(offset, resultRstStreamFrame.finalSize);
auto wireBuf = std::move(builtOut.second);
BufQueue queue;
@@ -2106,7 +2106,7 @@ TEST_F(QuicWriteCodecTest, WriteRstStream) {
auto& wireRstStreamFrame = *decodedFrame.asRstStreamFrame();
EXPECT_EQ(errorCode, wireRstStreamFrame.errorCode);
EXPECT_EQ(id, wireRstStreamFrame.streamId);
EXPECT_EQ(offset, wireRstStreamFrame.offset);
EXPECT_EQ(offset, wireRstStreamFrame.finalSize);
// At last, verify there is nothing left in the wire format bytes:
EXPECT_EQ(queue.chainLength(), 0);
}