lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Rename offset in RstStreamFrame to finalSize

Browse Source 
Summary: This will make it easier to distinguish between the `finalSize` and the `reliableSize` when we implement reliable resets

Reviewed By: hanidamlaj

Differential Revision: D64836474

fbshipit-source-id: d811d64a2538d4d1acba1ea10a7790d5905f02a4
This commit is contained in:
Aman Sharma
2024-11-14 11:36:01 -08:00
committed by Facebook GitHub Bot
parent 5b309dba06
commit 3f27fdebd9
10 changed files with 28 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
quic/api/test/QuicTransportTest.cpp
View File

@@ -2103,7 +2103,7 @@ TEST_F(QuicTransportTest, RstStream) {
continue;
}
EXPECT_EQ(streamId, rstFrame->streamId);
EXPECT_EQ(0, rstFrame->offset);
EXPECT_EQ(0, rstFrame->finalSize);
EXPECT_EQ(GenericApplicationErrorCode::UNKNOWN, rstFrame->errorCode);
rstFound = true;
}
@@ -2870,7 +2870,7 @@ TEST_F(QuicTransportTest, RstWrittenStream) {
continue;
}
EXPECT_EQ(streamId, rstStream->streamId);
EXPECT_EQ(currentWriteOffset, rstStream->offset);
EXPECT_EQ(currentWriteOffset, rstStream->finalSize);
EXPECT_EQ(GenericApplicationErrorCode::UNKNOWN, rstStream->errorCode);
foundReset = true;
}
@@ -2975,7 +2975,7 @@ TEST_F(QuicTransportTest, WriteAfterSendRst) {
continue;
}
EXPECT_EQ(streamId, rstFrame->streamId);
EXPECT_EQ(currentWriteOffset, rstFrame->offset);
EXPECT_EQ(currentWriteOffset, rstFrame->finalSize);
EXPECT_EQ(GenericApplicationErrorCode::UNKNOWN, rstFrame->errorCode);
foundReset = true;
}