lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Close the connection when the peer ACKs packets that were not sent

Browse Source 
Summary:
- Fail the connection if the peer acks future packets.
- Skip a packet number randomly and fail if the peer acks it
- Account for the skipped packet in the reorder distance when detecting losses
- Account for the skipped packet when implicitly acking crypto streams

Reviewed By: mjoras, kvtsoy

Differential Revision: D73120636

fbshipit-source-id: 661e4b418f9f015d6de627b67e1cf4d1fd81bb27
This commit is contained in:
Joseph Beshay
2025-04-25 14:56:55 -07:00
committed by Facebook GitHub Bot
parent 7b7c3eb88f
commit 3a2d60903e
10 changed files with 375 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

116
quic/api/test/QuicTransportFunctionsTest.cpp
View File

@@ -200,6 +200,8 @@ class QuicTransportFunctionsTest : public Test {
->setMaxLocalUnidirectionalStreams(
kDefaultMaxStreamsUnidirectional)
.hasError());
// Do not skip packet numbers for the tests.
conn->transportSettings.skipOneInNPacketSequenceNumber = 0;
return conn;
}
@@ -1220,6 +1222,70 @@ TEST_F(QuicTransportFunctionsTest, TestImplicitAck) {
EXPECT_TRUE(handshakeStream->lossBuffer.empty());
}
TEST_F(QuicTransportFunctionsTest, TestImplicitAckWithSkippedPacketNumber) {
auto conn = createConn();
auto data = IOBuf::copyBuffer("totally real crypto data");
data->coalesce();
auto initialStream =
getCryptoStream(*conn->cryptoState, EncryptionLevel::Initial);
ASSERT_TRUE(initialStream->pendingWrites.empty());
ASSERT_TRUE(initialStream->retransmissionBuffer.empty());
ASSERT_TRUE(initialStream->lossBuffer.empty());
auto packet = buildEmptyPacket(*conn, PacketNumberSpace::Initial);
packet.packet.frames.push_back(WriteCryptoFrame(0, data->length()));
initialStream->pendingWrites.append(data);
initialStream->writeBuffer.append(data->clone());
auto result1 = updateConnection(
*conn,
none,
packet.packet,
TimePoint(),
getEncodedSize(packet),
getEncodedBodySize(packet),
false /* isDSRPacket */);
ASSERT_FALSE(result1.hasError());
EXPECT_EQ(1, conn->outstandings.packetCount[PacketNumberSpace::Initial]);
EXPECT_EQ(1, conn->outstandings.packets.size());
EXPECT_EQ(1, initialStream->retransmissionBuffer.size());
// Skip a packet number
conn->ackStates.initialAckState->skippedPacketNum =
conn->ackStates.initialAckState->nextPacketNum;
increaseNextPacketNum(*conn, PacketNumberSpace::Initial);
packet = buildEmptyPacket(*conn, PacketNumberSpace::Initial);
packet.packet.frames.push_back(
WriteCryptoFrame(data->length(), data->length()));
packet.packet.frames.push_back(
WriteCryptoFrame(data->length() * 2, data->length()));
initialStream->pendingWrites.append(data);
initialStream->writeBuffer.append(data->clone());
initialStream->pendingWrites.append(data);
initialStream->writeBuffer.append(data->clone());
auto result2 = updateConnection(
*conn,
none,
packet.packet,
TimePoint(),
getEncodedSize(packet),
getEncodedBodySize(packet),
false /* isDSRPacket */);
ASSERT_FALSE(result2.hasError());
EXPECT_EQ(2, conn->outstandings.packetCount[PacketNumberSpace::Initial]);
EXPECT_EQ(2, conn->outstandings.packets.size());
EXPECT_EQ(3, initialStream->retransmissionBuffer.size());
EXPECT_TRUE(initialStream->pendingWrites.empty());
EXPECT_TRUE(initialStream->lossBuffer.empty());
implicitAckCryptoStream(*conn, EncryptionLevel::Initial);
EXPECT_EQ(0, conn->outstandings.packetCount[PacketNumberSpace::Initial]);
EXPECT_EQ(0, conn->outstandings.packets.size());
EXPECT_TRUE(initialStream->retransmissionBuffer.empty());
EXPECT_TRUE(initialStream->pendingWrites.empty());
EXPECT_TRUE(initialStream->lossBuffer.empty());
}
TEST_F(QuicTransportFunctionsTest, TestUpdateConnectionHandshakeCounter) {
auto conn = createConn();
conn->qLogger = std::make_shared<quic::FileQLogger>(VantagePoint::Client);
@@ -1761,6 +1827,56 @@ TEST_F(QuicTransportFunctionsTest, TestUpdateConnectionConnWindowUpdate) {
EXPECT_EQ(frame->maximumData, conn->flowControlState.advertisedMaxOffset);
}
TEST_F(QuicTransportFunctionsTest, TestUpdateConnectionSkipAPacketNumber) {
auto conn = createConn();
auto stream = conn->streamManager->createNextBidirectionalStream().value();
ASSERT_FALSE(
writeDataToQuicStream(*stream, folly::IOBuf::copyBuffer("12345"), false)
.hasError());
// Packet with CryptoFrame in AppData pn space
auto packet = buildEmptyPacket(*conn, PacketNumberSpace::AppData, true);
WriteStreamFrame writeStreamFrame(stream->id, 0, 5, false);
packet.packet.frames.push_back(std::move(writeStreamFrame));
ASSERT_FALSE(updateConnection(
*conn,
none,
packet.packet,
TimePoint(),
getEncodedSize(packet),
getEncodedBodySize(packet),
false /* isDSRPacket */)
.hasError());
ASSERT_FALSE(conn->ackStates.appDataAckState.skippedPacketNum.has_value());
// Force-skip a packet number
conn->transportSettings.skipOneInNPacketSequenceNumber = 1;
ASSERT_FALSE(
writeDataToQuicStream(*stream, folly::IOBuf::copyBuffer("67890"), true)
.hasError());
WriteStreamFrame writeStreamFrame2(stream->id, 0, 5, false);
packet.packet.frames.push_back(std::move(writeStreamFrame2));
auto sentPacketNumber = conn->ackStates.appDataAckState.nextPacketNum;
ASSERT_FALSE(updateConnection(
*conn,
none,
packet.packet,
TimePoint(),
getEncodedSize(packet),
getEncodedBodySize(packet),
false /* isDSRPacket */)
.hasError());
ASSERT_TRUE(conn->ackStates.appDataAckState.skippedPacketNum.has_value());
EXPECT_EQ(
conn->ackStates.appDataAckState.skippedPacketNum.value(),
sentPacketNumber + 1);
EXPECT_EQ(
conn->ackStates.appDataAckState.nextPacketNum, sentPacketNumber + 2);
}
TEST_F(QuicTransportFunctionsTest, StreamDetailsEmptyPacket) {
auto conn = createConn();
auto packet = buildEmptyPacket(*conn, PacketNumberSpace::AppData);