lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-07-30 14:43:05 +03:00
Code Activity

Accommodate old MVFST clients when attempting to intiate key updates

Browse Source 
Summary: Some old MVFST clients did not support key updates. This change prevents the server from initiating key updates to clients using the MVFST quic version until the client has initiated a key update. This ensures that key updates are triggered for clients that support them.

Reviewed By: mjoras

Differential Revision: D75022528

fbshipit-source-id: 7af2d65becbfefee347cbe98ccdfc01323cd153c
This commit is contained in:
Joseph Beshay
2025-05-20 14:04:58 -07:00
committed by Facebook GitHub Bot
parent c8cf18752b
commit 371f19df8e
2 changed files with 126 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
quic/api/QuicTransportFunctions.cpp
View File

@ -2228,6 +2228,10 @@ folly::Expected<folly::Unit, QuicError> maybeHandleIncomingKeyUpdate(
}
conn.readCodec->setNextOneRttReadCipher(
std::move(nextOneRttReadCipherResult.value()));
// The peer has initiated a key update. We should use the regular key
// update interval if we are initiating key updates.
conn.transportSettings.firstKeyUpdatePacketCount.reset();
}
return folly::unit;
}
@ -2235,6 +2239,14 @@ folly::Expected<folly::Unit, QuicError> maybeHandleIncomingKeyUpdate(
folly::Expected<folly::Unit, QuicError> maybeInitiateKeyUpdate(
QuicConnectionStateBase& conn) {
if (conn.transportSettings.initiateKeyUpdate) {
if (conn.nodeType == QuicNodeType::Server && conn.version.has_value() &&
conn.version.value() == QuicVersion::MVFST &&
conn.transportSettings.firstKeyUpdatePacketCount.has_value()) {
// Some old versions of MVFST did not support key updates.
// So as the server, do not attempt to initiate key updates if the client
// hasn't initiated one yet.
return folly::unit;
}
auto packetsBeforeNextUpdate =
conn.transportSettings.firstKeyUpdatePacketCount
? conn.transportSettings.firstKeyUpdatePacketCount.value()
@ -2244,6 +2256,9 @@ folly::Expected<folly::Unit, QuicError> maybeInitiateKeyUpdate(
conn.readCodec->canInitiateKeyUpdate()) {
QUIC_STATS(conn.statsCallback, onKeyUpdateAttemptInitiated);
conn.readCodec->advanceOneRttReadPhase();
//  We have initiated a key update. We should use the regular key
// update from now on.
conn.transportSettings.firstKeyUpdatePacketCount.reset();
auto nextOneRttWriteCipherResult =