From 2bdb9b0dcc47fd1b538b587a1c4d4de112f1119d Mon Sep 17 00:00:00 2001 From: Shawn Shihang Wei Date: Mon, 30 Sep 2019 18:48:21 -0700 Subject: [PATCH] Revert D15267820: [quic] Add unit test for sending RetireConnectionIdFrame Differential Revision: D15267820 Original commit changeset: b885ca6b5dfa fbshipit-source-id: 899b6773521a347f06972d69e6be8456dc4e9e7d --- quic/api/test/QuicTransportTest.cpp | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/quic/api/test/QuicTransportTest.cpp b/quic/api/test/QuicTransportTest.cpp index 308811f01..ae5ef6c3a 100644 --- a/quic/api/test/QuicTransportTest.cpp +++ b/quic/api/test/QuicTransportTest.cpp @@ -1483,33 +1483,6 @@ TEST_F(QuicTransportTest, ResendNewConnectionIdOnLoss) { [&](auto&) { return false; })); } -TEST_F(QuicTransportTest, SendRetireConnectionIdFrame) { - EXPECT_CALL(*socket_, write(_, _)).WillOnce(Invoke(bufLength)); - auto& conn = transport_->getConnectionState(); - RetireConnectionIdFrame retireConnId(1); - sendSimpleFrame(conn, retireConnId); - transport_->updateWriteLooper(true); - loopForWrites(); - - EXPECT_TRUE(conn.pendingEvents.frames.empty()); - EXPECT_EQ(1, transport_->getConnectionState().outstandingPackets.size()); - auto packet = - getLastOutstandingPacket( - transport_->getConnectionState(), PacketNumberSpace::AppData) - ->packet; - bool foundRetireConnectionId = false; - for (auto& simpleFrame : all_frames(packet.frames)) { - folly::variant_match( - simpleFrame, - [&](const RetireConnectionIdFrame& frame) { - EXPECT_EQ(frame, retireConnId); - foundRetireConnectionId = true; - }, - [&](auto&) {}); - } - EXPECT_TRUE(foundRetireConnectionId); -} - TEST_F(QuicTransportTest, NonWritableStreamAPI) { auto streamId = transport_->createBidirectionalStream().value(); auto buf = buildRandomInputData(20);