lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-10 21:22:20 +03:00
Code Activity

remove constraints of 4-bytes minimum len for connection-id

Browse Source 
Summary:
New QUIC draft no longer has this limitation for connection-id, and allows
connid of len 0 -> 20.

This diff removes the constraints. I still kept the requirement for
*server-chosen* conn-id

Reviewed By: mjoras, lnicco

Differential Revision: D19507366

fbshipit-source-id: 4c73f45617f40b29d47d2d86b7598f6c95588d0a
This commit is contained in:
Udip Pant
2020-01-23 21:57:43 -08:00
committed by Facebook Github Bot
parent e279022ce5
commit 21a7efb2e3
8 changed files with 26 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
quic/codec/Decode.cpp
View File

@@ -500,7 +500,7 @@ NewConnectionIdFrame decodeNewConnectionIdFrame(folly::io::Cursor& cursor) {
quic::TransportErrorCode::FRAME_ENCODING_ERROR,
quic::FrameType::NEW_CONNECTION_ID);
}
if (connIdLen < kMinConnectionIdSize || connIdLen > kMaxConnectionIdSize) {
if (connIdLen > kMaxConnectionIdSize) {
throw QuicTransportException(
"ConnectionId invalid length",
quic::TransportErrorCode::FRAME_ENCODING_ERROR,