lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-25 15:43:13 +03:00
Code Activity

Convert some write-side exceptions to CHECKs

Browse Source 
Summary: These aren't controlled by the peer, they would represent internal  programming bugs and qualify as invariants. Trying to handle these as connection-ending rather than process-ending requires excessive plumbing for dubious value.

Reviewed By: jbeshay, kvtsoy

Differential Revision: D71744341

fbshipit-source-id: 6a9768bc2f26c2dcc07b722f43779b712b713951
This commit is contained in:
Matt Joras
2025-03-27 11:13:33 -07:00
committed by Facebook GitHub Bot
parent 58eb799ea0
commit 19a4718785
4 changed files with 16 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
quic/codec/QuicWriteCodec.cpp
View File

@@ -106,8 +106,7 @@ folly::Expected<Optional<uint64_t>, QuicError> writeStreamFrameHeader(
} else {
// This should never really happen as dataLen is bounded by the remaining
// space in the packet which should be << kEightByteLimit.
throw QuicInternalException(
"Stream frame length too large.", LocalErrorCode::INTERNAL_ERROR);
LOG(FATAL) << "Stream frame length too large.";
}
}
if (dataLenLen > 0) {
@@ -198,11 +197,8 @@ Optional<WriteCryptoFrame> writeCryptoFrame(
size_t writableData = std::min(dataLength, spaceRemaining);
QuicInteger lengthVarInt(writableData);
if (lengthVarInt.getSize() > lengthBytes) {
throw QuicInternalException(
std::string("Length bytes representation"),
LocalErrorCode::CODEC_ERROR);
}
CHECK(lengthVarInt.getSize() <= lengthBytes)
<< "Length bytes representation exceeds allocated space";
builder.write(intFrameType);
builder.write(offsetInteger);
builder.write(lengthVarInt);
@@ -1070,11 +1066,7 @@ size_t writeFrame(QuicWriteFrame&& frame, PacketBuilderInterface& builder) {
return size_t(0);
}
default: {
auto errorStr = folly::to<std::string>(
"Unknown / unsupported frame type received at ", __func__);
VLOG(2) << errorStr;
throw QuicTransportException(
errorStr, TransportErrorCode::FRAME_ENCODING_ERROR);
LOG(FATAL) << "Unknown / unsupported frame type received";
}
}
}