lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-09 20:42:44 +03:00
Code Activity

fix connection migration deadlock

Browse Source 
Summary: Currently, we can enter a deadlock situation where a client rx's a PathChallenge frame, but the packet containing its respective PathResposne frame is lost/delayed. Clients should re-tx the PathResponse frame upon PTO/loss.

Reviewed By: jbeshay

Differential Revision: D43718357

fbshipit-source-id: 26b4bc64dbf48417558eda02744f321f1cb73148
This commit is contained in:
Hani Damlaj
2023-03-17 20:36:56 -07:00
committed by Facebook GitHub Bot
parent 450dd51644
commit 104b9848bc
3 changed files with 26 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
quic/api/test/QuicTransportTest.cpp
View File

@@ -2480,26 +2480,37 @@ TEST_F(QuicTransportTest, ClonePathResponse) {
conn.outstandings.packets.begin(),
conn.outstandings.packets.end(),
findFrameInPacketFunc<QuicSimpleFrame::Type::PathResponseFrame>());
EXPECT_EQ(numPathResponsePackets, 1);
EXPECT_EQ(numPathResponsePackets, 2);
}
TEST_F(QuicTransportTest, DoNotResendPathResponseOnLoss) {
TEST_F(QuicTransportTest, ResendPathResponseOnLoss) {
auto& conn = transport_->getConnectionState();
auto& outstandingPackets = conn.outstandings.packets;
EXPECT_EQ(conn.pendingEvents.frames.size(), 0);
PathResponseFrame pathResponse(123);
sendSimpleFrame(conn, pathResponse);
EXPECT_EQ(conn.pendingEvents.frames.size(), 1);
sendSimpleFrame(conn, PathResponseFrame(folly::Random::rand64()));
transport_->updateWriteLooper(true);
loopForWrites();
EXPECT_EQ(conn.pendingEvents.frames.size(), 0);
EXPECT_EQ(1, conn.outstandings.packets.size());
auto packet =
// pathResponseFrame should no longer be in pendingEvents
EXPECT_EQ(conn.pendingEvents.frames.size(), 0);
// verify presence of frame in outstanding packet
EXPECT_EQ(outstandingPackets.size(), 1);
auto& packet =
getLastOutstandingPacket(conn, PacketNumberSpace::AppData)->packet;
auto numPathResponseFrames = std::count_if(
outstandingPackets.begin(),
outstandingPackets.end(),
findFrameInPacketFunc<QuicSimpleFrame::Type::PathResponseFrame>());
EXPECT_EQ(numPathResponseFrames, 1);
// pathResponseFrame should be queued for re-tx on packet loss
markPacketLoss(conn, packet, false);
EXPECT_EQ(conn.pendingEvents.frames.size(), 0);
EXPECT_EQ(conn.pendingEvents.frames.size(), 1);
numPathResponseFrames = std::count_if(
conn.pendingEvents.frames.begin(),
conn.pendingEvents.frames.end(),
[](const auto& frame) { return frame.asPathResponseFrame(); });
EXPECT_EQ(numPathResponseFrames, 1);
}
TEST_F(QuicTransportTest, SendNewConnectionIdFrame) {