diff --git a/quic/api/LoopDetectorCallback.h b/quic/api/LoopDetectorCallback.h index 3a3a110f2..072542248 100644 --- a/quic/api/LoopDetectorCallback.h +++ b/quic/api/LoopDetectorCallback.h @@ -15,7 +15,8 @@ namespace quic { class LoopDetectorCallback { public: virtual ~LoopDetectorCallback() = default; - virtual void onSuspiciousLoops( + + virtual void onSuspiciousWriteLoops( uint64_t emptyLoopCount, WriteDataReason writeReason, NoWriteReason noWriteReason, diff --git a/quic/api/QuicTransportBase.cpp b/quic/api/QuicTransportBase.cpp index 26153b7e0..0ccd6dac8 100644 --- a/quic/api/QuicTransportBase.cpp +++ b/quic/api/QuicTransportBase.cpp @@ -2299,7 +2299,7 @@ void QuicTransportBase::writeSocketData() { // TODO: Currently we will to get some stats first. Then we may filter // out some errors here. For example, socket fail to write might be a // legit case to filter out. - conn_->loopDetectorCallback->onSuspiciousLoops( + conn_->loopDetectorCallback->onSuspiciousWriteLoops( ++conn_->debugState.currentEmptyLoopCount, conn_->debugState.writeDataReason, conn_->debugState.noWriteReason, diff --git a/quic/api/test/Mocks.h b/quic/api/test/Mocks.h index 6a061d77f..1807a375c 100644 --- a/quic/api/test/Mocks.h +++ b/quic/api/test/Mocks.h @@ -276,7 +276,7 @@ class MockLoopDetectorCallback : public LoopDetectorCallback { public: ~MockLoopDetectorCallback() override = default; MOCK_METHOD4( - onSuspiciousLoops, + onSuspiciousWriteLoops, void(uint64_t, WriteDataReason, NoWriteReason, const std::string&)); }; diff --git a/quic/api/test/QuicTransportTest.cpp b/quic/api/test/QuicTransportTest.cpp index fafa2e2d5..3837cd35d 100644 --- a/quic/api/test/QuicTransportTest.cpp +++ b/quic/api/test/QuicTransportTest.cpp @@ -1357,7 +1357,7 @@ TEST_F(QuicTransportTest, BusyWriteLoopDetection) { EXPECT_CALL(*socket_, write(_, _)).Times(0); EXPECT_CALL( *rawLoopDetectorCallback, - onSuspiciousLoops(1, WriteDataReason::STREAM_WINDOW_UPDATE, _, _)) + onSuspiciousWriteLoops(1, WriteDataReason::STREAM_WINDOW_UPDATE, _, _)) .Times(1); loopForWrites(); EXPECT_EQ(1, conn.outstandingPackets.size());