lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-01 01:44:22 +03:00
Code Activity

Remove forcible setting of ContinuousMemory

Browse Source 
Summary: Previously, we didn't support all combinations of (batching mode, data path type).

Reviewed By: mjoras

Differential Revision: D73280506

fbshipit-source-id: 752a1eda4f58a19f86410bff514415017ffdb383
This commit is contained in:
Aman Sharma
2025-04-21 10:30:20 -07:00
committed by Facebook GitHub Bot
parent b90551c3bb
commit 0c5295f4ef
3 changed files with 1 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
quic/api/QuicTransportFunctions.cpp
View File

@ -1641,20 +1641,6 @@ folly::Expected<WriteQuicDataResult, QuicError> writeConnectionDataToSocket(
return folly::makeUnexpected(gsoResult.error());
}
connection.gsoSupported = sock.getGSO().value() >= 0;
if (!*connection.gsoSupported) {
if (!useSinglePacketInplaceBatchWriter(
connection.transportSettings.maxBatchSize,
connection.transportSettings.dataPathType) &&
(connection.transportSettings.dataPathType ==
DataPathType::ContinuousMemory)) {
// Change data path type to DataPathType::ChainedMemory.
// Continuous memory data path is only supported with working GSO or
// SinglePacketInplaceBatchWriter.
LOG(ERROR) << "Switching data path to ChainedMemory as "
<< "GSO is not supported on the socket";
connection.transportSettings.dataPathType = DataPathType::ChainedMemory;
}
}
}
auto batchWriter = BatchWriterFactory::makeBatchWriter(