lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-25 15:43:13 +03:00
Code Activity

Use MVFST_EXPERIMENTAL for cwnd tuning

Browse Source 
Reviewed By: mjoras

Differential Revision: D55938590

fbshipit-source-id: d8dd289aa18796343580db074b17c6d9d5ef8b68
This commit is contained in:
Luca Niccolini
2024-04-10 15:29:35 -07:00
committed by Facebook GitHub Bot
parent 94c5d6a30e
commit 0aa19f6897
3 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
quic/QuicConstants.h
View File

@@ -341,6 +341,7 @@ enum class QuicVersion : uint32_t {
MVFST = 0xfaceb002, MVFST = 0xfaceb002,
QUIC_V1 = 0x00000001, QUIC_V1 = 0x00000001,
QUIC_V1_ALIAS = 0xfaceb003, QUIC_V1_ALIAS = 0xfaceb003,
// MVFST_EXPERIMENTAL used to set initial congestion window
MVFST_EXPERIMENTAL = 0xfaceb00e, // Experimental alias for MVFST MVFST_EXPERIMENTAL = 0xfaceb00e, // Experimental alias for MVFST
MVFST_ALIAS = 0xfaceb010, MVFST_ALIAS = 0xfaceb010,
MVFST_INVALID = 0xfaceb00f, MVFST_INVALID = 0xfaceb00f,

3
quic/server/QuicServerWorker.cpp
View File

@@ -650,6 +650,9 @@ QuicServerTransport::Ptr QuicServerWorker::makeTransport(
} }
trans->setCongestionControllerFactory(ccFactory_); trans->setCongestionControllerFactory(ccFactory_);
trans->setTransportStatsCallback(statsCallback_.get()); // ok if nullptr trans->setTransportStatsCallback(statsCallback_.get()); // ok if nullptr
if (quicVersion == QuicVersion::MVFST_EXPERIMENTAL) {
transportSettings_.initCwndInMss = 35;
}
auto transportSettings = transportSettingsOverrideFn_ auto transportSettings = transportSettingsOverrideFn_
? transportSettingsOverrideFn_( ? transportSettingsOverrideFn_(

2
quic/server/state/ServerStateMachine.cpp
View File

@@ -93,6 +93,8 @@ void recoverOrResetCongestionAndRttState(
void maybeSetExperimentalSettings(QuicServerConnectionState& conn) { void maybeSetExperimentalSettings(QuicServerConnectionState& conn) {
// no-op versions // no-op versions
if (conn.version == QuicVersion::MVFST_EXPERIMENTAL) { if (conn.version == QuicVersion::MVFST_EXPERIMENTAL) {
// MVFST_EXPERIMENTAL is used to set initCwnd
// QuicServerWorker.cpp before CC is initialized.
} else if (conn.version == QuicVersion::MVFST_EXPERIMENTAL2) { } else if (conn.version == QuicVersion::MVFST_EXPERIMENTAL2) {
} else if (conn.version == QuicVersion::MVFST_EXPERIMENTAL3) { } else if (conn.version == QuicVersion::MVFST_EXPERIMENTAL3) {
} }