lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Remove throws from socket layer

Browse Source 
Summary: More in the theme of returning Expected instead of throwing. For the folly case, we keep the try/catches in there and translate to Expected. For Libev, we convert directly to Expected.

Reviewed By: kvtsoy

Differential Revision: D73217128

fbshipit-source-id: d00a978f24e3b29a77a8ac99a19765ae49f64df8
This commit is contained in:
Matt Joras
2025-04-19 15:20:15 -07:00
committed by Facebook GitHub Bot
parent e196f31741
commit 089bf581a7
41 changed files with 2057 additions and 692 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -651,6 +651,19 @@ class QuicTransportImplTest : public Test {
qEvb = std::make_shared<FollyQuicEventBase>(fEvb.get());
auto socket =
std::make_unique<NiceMock<quic::test::MockAsyncUDPSocket>>(qEvb);
ON_CALL(*socket, setAdditionalCmsgsFunc(_))
.WillByDefault(Return(folly::unit));
ON_CALL(*socket, close()).WillByDefault(Return(folly::unit));
ON_CALL(*socket, resumeWrite(_)).WillByDefault(Return(folly::unit));
ON_CALL(*socket, bind(_)).WillByDefault(Return(folly::unit));
ON_CALL(*socket, connect(_)).WillByDefault(Return(folly::unit));
ON_CALL(*socket, setReuseAddr(_)).WillByDefault(Return(folly::unit));
ON_CALL(*socket, setReusePort(_)).WillByDefault(Return(folly::unit));
ON_CALL(*socket, setRecvTos(_)).WillByDefault(Return(folly::unit));
ON_CALL(*socket, getRecvTos()).WillByDefault(Return(false));
ON_CALL(*socket, getGSO()).WillByDefault(Return(0));
ON_CALL(*socket, setCmsgs(_)).WillByDefault(Return(folly::unit));
ON_CALL(*socket, appendCmsgs(_)).WillByDefault(Return(folly::unit));
socketPtr = socket.get();
transport = std::make_shared<TestQuicTransport>(
qEvb, std::move(socket), &connSetupCallback, &connCallback);
@@ -3378,7 +3391,7 @@ TEST_P(QuicTransportImplTestBase, UncleanShutdownEventBase) {
TEST_P(QuicTransportImplTestBase, GetLocalAddressBoundSocket) {
SocketAddress addr("127.0.0.1", 443);
EXPECT_CALL(*socketPtr, isBound()).WillOnce(Return(true));
EXPECT_CALL(*socketPtr, address()).WillRepeatedly(ReturnRef(addr));
EXPECT_CALL(*socketPtr, addressRef()).WillRepeatedly(ReturnRef(addr));
SocketAddress localAddr = transport->getLocalAddress();
EXPECT_TRUE(localAddr == addr);
}
@@ -4859,9 +4872,7 @@ TEST_P(
// Write event is not armed.
EXPECT_CALL(*socketPtr, isWritableCallbackSet()).WillOnce(Return(false));
EXPECT_CALL(*socketPtr, resumeWrite(_))
.WillOnce(Return(
folly::makeExpected<folly::AsyncSocketException>(folly::Unit())));
EXPECT_CALL(*socketPtr, resumeWrite(_)).WillOnce(Return(folly::unit));
transport->maybeStopWriteLooperAndArmSocketWritableEvent();
// Write looper is stopped.
EXPECT_FALSE(transport->writeLooper()->isRunning());
@@ -5072,7 +5083,7 @@ TEST_P(
EXPECT_CALL(*socketPtr, resumeWrite(_))
.WillOnce(Invoke([&](QuicAsyncUDPSocket::WriteCallback*) {
writeCallbackArmed = true;
return folly::makeExpected<folly::AsyncSocketException>(folly::Unit());
return folly::unit;
}));
// Fail the first write loop.