lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Move ByteEventCallback to QuicCallbacks.h

Browse Source 
Summary:
The purpose of this is so that we can import this header from the WebTransport implementation and use the `ByteEventCallback` directly instead of creating a wrapper, thereby saving an allocation.

There's no functional change in this commit, it's just moving things around.

Relevant files:
* quic/api/QuicCallbacks.h
* quic/api/QuicSocketLite.h

Reviewed By: hanidamlaj

Differential Revision: D70000563

fbshipit-source-id: 9523cc788f50b4ba218be33e84f7d5b4f44a73c2
This commit is contained in:
Aman Sharma
2025-02-25 17:58:37 -08:00
committed by Facebook GitHub Bot
parent 00d442b8bc
commit 07f91b0698
8 changed files with 78 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -34,8 +34,6 @@ using namespace folly;
namespace quic::test {
constexpr uint8_t kStreamIncrement = 0x04;
using ByteEvent = QuicTransportBase::ByteEvent;
using ByteEventCancellation = QuicTransportBase::ByteEventCancellation;
enum class TestFrameType : uint8_t {
STREAM,
@@ -166,7 +164,7 @@ class TestPingCallback : public QuicSocket::PingCallback {
void onPing() noexcept override {}
};
class TestByteEventCallback : public QuicSocket::ByteEventCallback {
class TestByteEventCallback : public ByteEventCallback {
public:
using HashFn = std::function<size_t(const ByteEvent&)>;
using ComparatorFn = std::function<bool(const ByteEvent&, const ByteEvent&)>;