lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-06 22:22:38 +03:00
Code Activity

fix onBidirectionalStreamsAvailable

Browse Source 
Summary:
fixes the arg passed to the ::onBidirectionalStreamsAvailable callback

#facebook:
i accidentally introduced a bad operator precedence bug in a refactor; this fixes that and the unit test

luckily HQSession doesn't consume the argument passed to the callback

Reviewed By: knekritz

Differential Revision: D62765762

fbshipit-source-id: 7ae206d5036fc744485736f92fd366ce99103d58
This commit is contained in:
Hani Damlaj
2024-09-17 00:11:53 -07:00
committed by Facebook GitHub Bot
parent b009969fe3
commit 07f2980f43
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
quic/api/QuicTransportBase.cpp
View File

@@ -1064,15 +1064,17 @@ void QuicTransportBase::invokeStreamsAvailableCallbacks() {
if (conn_->streamManager->consumeMaxLocalBidirectionalStreamIdIncreased()) { if (conn_->streamManager->consumeMaxLocalBidirectionalStreamIdIncreased()) {
// check in case new streams were created in preceding callbacks // check in case new streams were created in preceding callbacks
// and max is already reached // and max is already reached
if (auto numStreams = getNumOpenableBidirectionalStreams() > 0) { auto numOpenableStreams = getNumOpenableBidirectionalStreams();
connCallback_->onBidirectionalStreamsAvailable(numStreams); if (numOpenableStreams > 0) {
connCallback_->onBidirectionalStreamsAvailable(numOpenableStreams);
} }
} }
if (conn_->streamManager->consumeMaxLocalUnidirectionalStreamIdIncreased()) { if (conn_->streamManager->consumeMaxLocalUnidirectionalStreamIdIncreased()) {
// check in case new streams were created in preceding callbacks // check in case new streams were created in preceding callbacks
// and max is already reached // and max is already reached
if (auto numStreams = getNumOpenableUnidirectionalStreams() > 0) { auto numOpenableStreams = getNumOpenableUnidirectionalStreams();
connCallback_->onUnidirectionalStreamsAvailable(numStreams); if (numOpenableStreams > 0) {
connCallback_->onUnidirectionalStreamsAvailable(numOpenableStreams);
} }
} }
} }

10
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -1636,13 +1636,15 @@ TEST_P(QuicTransportImplTestBase, onBidiStreamsAvailableCallback) {
EXPECT_CALL(connCallback, onBidirectionalStreamsAvailable(_)) EXPECT_CALL(connCallback, onBidirectionalStreamsAvailable(_))
.WillOnce(Invoke([](uint64_t numAvailableStreams) { .WillOnce(Invoke([](uint64_t numAvailableStreams) {
EXPECT_EQ(numAvailableStreams, 1); EXPECT_EQ(numAvailableStreams, 10);
})); }));
transport->addMaxStreamsFrame(MaxStreamsFrame(1, /*isBidirectionalIn=*/true)); transport->addMaxStreamsFrame(
EXPECT_EQ(transport->getNumOpenableBidirectionalStreams(), 1); MaxStreamsFrame(10, /*isBidirectionalIn=*/true));
EXPECT_EQ(transport->getNumOpenableBidirectionalStreams(), 10);
// same value max streams frame doesn't trigger callback // same value max streams frame doesn't trigger callback
transport->addMaxStreamsFrame(MaxStreamsFrame(1, /*isBidirectionalIn=*/true)); transport->addMaxStreamsFrame(
MaxStreamsFrame(10, /*isBidirectionalIn=*/true));
} }
TEST_P(QuicTransportImplTestBase, onBidiStreamsAvailableCallbackAfterExausted) { TEST_P(QuicTransportImplTestBase, onBidiStreamsAvailableCallbackAfterExausted) {