lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-07-30 14:43:05 +03:00
Code Activity

Don't special case stream frames for opportunistic ACKing

Browse Source 
Summary: This was added to not bundle ACKs with stream frames. Don't special case those and also disabling opportunistic ACKing for all write reasons.

Reviewed By: jbeshay

Differential Revision: D66514392

fbshipit-source-id: f2657a5c06ea8ae37b8c8eacd04c5a3b8ac75390
This commit is contained in:
Matt Joras
2024-11-26 19:54:04 -08:00
committed by Facebook GitHub Bot
parent 2322ee8c8b
commit 058f5db28c
2 changed files with 40 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
quic/api/QuicTransportFunctions.cpp
View File

@ -186,11 +186,9 @@ WriteQuicDataResult writeQuicDataToSocketImpl(
.pingFrames()
.datagramFrames()
.immediateAckFrames();
// Only add ACK frames if we need to send an ACK, or if the write reason isn't
// just streams.
// Only add ACK frames if we need to send an ACK.
if (connection.transportSettings.opportunisticAcking ||
toWriteAppDataAcks(connection) ||
(hasNonAckDataToWrite(connection) != WriteDataReason::STREAM)) {
toWriteAppDataAcks(connection)) {
schedulerBuilder.ackFrames();
}
if (!exceptCryptoStream) {