lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Prioritize read callbacks for unidirectional/control streams

Browse Source 
Summary: Prioritize read callbacks for unidirectional/control streams optionally.

Reviewed By: mjoras

Differential Revision: D64439116

fbshipit-source-id: b4fe424db99921558d4672d9b21e992369072ca9
This commit is contained in:
Konstantin Tsoy
2024-10-16 12:10:44 -07:00
committed by Facebook GitHub Bot
parent cbd22e95e2
commit 013bf7cc34
6 changed files with 204 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -960,6 +960,52 @@ TEST_P(QuicTransportImplTestBase, ReadCallbackDataAvailable) {
transport.reset();
}
TEST_P(
QuicTransportImplTestBase,
ReadCallbackDataAvailableWithUnidirPrioritized) {
InSequence seq;
auto transportSettings = transport->getTransportSettings();
transportSettings.unidirectionalStreamsReadCallbacksFirst = true;
transport->setTransportSettings(transportSettings);
auto& streamManager = *transport->transportConn->streamManager;
auto nextPeerUniStream =
streamManager.nextAcceptablePeerUnidirectionalStreamId();
EXPECT_TRUE(nextPeerUniStream.has_value());
StreamId qpackStream = streamManager.getStream(*nextPeerUniStream)->id;
auto requestStream = transport->createBidirectionalStream().value();
NiceMock<MockReadCallback> requestStreamCb;
NiceMock<MockReadCallback> qpackStreamCb;
transport->setReadCallback(requestStream, &requestStreamCb);
transport->setReadCallback(qpackStream, &qpackStreamCb);
transport->addDataToStream(
qpackStream,
StreamBuffer(
folly::IOBuf::copyBuffer(
"and i'm qpack data i will block you no tomorrow"),
0));
transport->addDataToStream(
requestStream, StreamBuffer(folly::IOBuf::copyBuffer("i'm headers"), 0));
bool qpackCbCalled = false;
EXPECT_CALL(qpackStreamCb, readAvailable(qpackStream))
.WillOnce(Invoke([&](StreamId) {
EXPECT_FALSE(qpackCbCalled);
qpackCbCalled = true;
}));
EXPECT_CALL(requestStreamCb, readAvailable(requestStream))
.WillOnce(Invoke([&](StreamId) { EXPECT_TRUE(qpackCbCalled); }));
transport->driveReadCallbacks();
transport.reset();
}
TEST_P(QuicTransportImplTestBase, ReadCallbackDataAvailableNoReap) {
auto stream1 = transport->createBidirectionalStream().value();
auto stream2 = transport->createBidirectionalStream().value();