lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-24 04:01:07 +03:00
Code Activity

TODO comment cleanup.

Browse Source 
Summary:
These are either no longer relevant, are unlikely to be done, or are spculative enough that they don't deserve code space.

Hope here is to make our search for TODOs higher signal.

Reviewed By: lnicco

Differential Revision: D29769792

fbshipit-source-id: 7cfa62cdc15e72d8b7b0cd5dbb5913ea3ca3dc5a
This commit is contained in:
Matt Joras
2021-07-20 10:26:47 -07:00
committed by Facebook GitHub Bot
parent a42ff303ad
commit 003f012cb7
27 changed files with 3 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
quic/codec/Decode.cpp
View File

@@ -569,7 +569,6 @@ NewConnectionIdFrame decodeNewConnectionIdFrame(folly::io::Cursor& cursor) {
RetireConnectionIdFrame decodeRetireConnectionIdFrame(
folly::io::Cursor& cursor) {
// TODO we parse this frame, but return NoopFrame. Add proper support for it!
auto sequenceNum = decodeQuicInteger(cursor);
if (!sequenceNum) {
throw QuicTransportException(
@@ -746,7 +745,6 @@ QuicFrame parseFrame(
const CodecParameters& params) {
folly::io::Cursor cursor(queue.front());
auto frameTypeInt = decodeQuicInteger(cursor);
// TODO add an new api to determine whether the frametype is encoded minimally
if (!frameTypeInt) {
throw QuicTransportException(
"Invalid frame-type field", TransportErrorCode::FRAME_ENCODING_ERROR);