mbedtls/conditionalize-mbedtls_mpi_sub_abs-memcpy.txt at 2.28-sphinx-versioned-documentation - mbedtls - GitFox

lib/mbedtls

mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-08-08 17:42:09 +03:00

Files

Aaron M. Ucko 78b823ab0e mbedtls_mpi_sub_abs: Skip memcpy when redundant (#6701 ).

In some contexts, the output pointer may equal the first input
pointer, in which case copying is not only superfluous but results in
"Source and destination overlap in memcpy" errors from Valgrind (as I
observed in the context of ecp_double_jac) and a diagnostic message
from TrustInSoft Analyzer (as Pascal Cuoq reported in the context of
other ECP functions called by cert-app with a suitable certificate).

Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>

2023-01-31 15:45:44 -05:00

5 lines

196 B

Plaintext

Raw Permalink Blame History

 Bugfix
    * Fix potential undefined behavior in mbedtls_mpi_sub_abs().  Reported by
      Pascal Cuoq using TrustInSoft Analyzer in #6701; observed independently by
      Aaron Ucko under Valgrind.