Werner Lewis
e53be35c09
Remove unused imports
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 17:07:42 +01:00
Werner Lewis
0d07e86a44
Rework TestGenerator to add file targets
...
BaseTarget-derived targets are now added to TestGenerator.targets in
initialization. This reduces repeated code in generate_xxx_tests.py
scripts which use this framework.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 17:07:37 +01:00
Werner Lewis
6cc5e5f0d9
Use Python 3.5 style typing for dependencies
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:49:13 +01:00
Werner Lewis
486b3410a4
Add dependencies attribute to BaseTarget
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:49:13 +01:00
Werner Lewis
18f94d8175
Use combinations_with_replacement
for inputs
...
When generating combinations of values, `itertools.combinations` will
not allow inputs to be repeated. This is replaced so that cases where
input values match are generated, i.e. ("0", "0").
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:49:13 +01:00
Werner Lewis
2b0f7d8d56
Modify wording in docstrings
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:49:13 +01:00
Werner Lewis
6f67bae527
Fix trailing whitespace
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:48:39 +01:00
Werner Lewis
ac86390da8
Use argparser default for targets
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:48:39 +01:00
Werner Lewis
b03420fb3b
Clarify documentation
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:47:33 +01:00
Werner Lewis
b29f59f5ff
Disable abstract check in pylint
...
Version of pylint used in CI does not recognize abstract subclasses of
BaseTarget, so disable warning in these abstract classes.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
412c497cbe
Fix TARGET types and code style
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
d77d33defb
Raise NotImplementedError in abstract methods
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
486d25850f
Disable pylint unused arg in __new__
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
478a4ce1fe
Use typing casts for fixed-width tuples
...
Enforces fixed-width tuple types where mypy does not recognize.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
9509f44d79
Add missing typing
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
6d04142972
Remove trailing whitespace in description
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
cace1aa02e
Use __new__() for case counting
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
c34d037fa0
Split generate_tests to reduce code complexity
...
Previous implementation mixed the test case generation and the
recursive generation calls together. A separate method is added to
generate test cases for the current class' test function. This reduces
the need to override generate_tests().
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
47e37b3b75
Use ABCMeta for abstract classes
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
008d90d424
Add details to docstrings
...
Clarification is added to docstrings, mostly in abstract classes.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
1c2a732203
Convert bools to int before arithmetic
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
02998c470a
Remove unneeded list concatenation
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
70d3f3dcdc
Remove abbreviations and clarify attributes
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
dcad1e93fe
Separate common test generation classes/functions
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:46:39 +01:00
Werner Lewis
92bb1cd8cb
Fix incorrect indentation
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:29:49 +01:00
Werner Lewis
f0910ae380
Remove is None from if statement
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:29:49 +01:00
Werner Lewis
d76c5edc8e
Fix type issues
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:29:49 +01:00
Werner Lewis
1bdee226e3
Remove set() to preserve test case order
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:29:49 +01:00
Werner Lewis
1c413bda51
Sort tests when generating cases
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:29:49 +01:00
Werner Lewis
5c1173bc1b
Add test case generation for bignum add
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:29:49 +01:00
Werner Lewis
423f99bcef
Add test generation for bignum cmp variant
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:29:49 +01:00
Werner Lewis
545911f751
Add bignum test generation framework
...
Adds python script for generation of bignum test cases, with initial
classes for mpi_cmp_mpi test cases. Build scripts are updated to
generate test data.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-21 16:29:49 +01:00
Manuel Pégourié-Gonnard
e9ff465709
Merge pull request #6302 from davidhorstmann-arm/2.28-syntax-highlighting-function-files
...
[Backport 2.28] Use GitHub C syntax highlighting on test files
2022-09-21 10:52:17 +02:00
David Horstmann
6af9ad321c
Use GitHub C syntax highlighting on test files
...
Add a .gitattributes file that tells GitHub to highlight all .function
files as if they were .c files. This aids in reviewing changes to tests.
Signed-off-by: David Horstmann <david.horstmann@arm.com >
2022-09-20 17:24:07 +01:00
Werner Lewis
2b984dea77
Restore vbuf value after modification
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-20 12:07:39 +01:00
Werner Lewis
9a3463c9b7
Add explicit mbedtls_ecp_tls_read_group_id call
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-20 10:03:24 +01:00
Werner Lewis
c1498b3eb0
Add leading zeros to group metadata
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-20 10:03:24 +01:00
Werner Lewis
fad4030f90
Fix typo in MBEDTLS_ECP_DP_BP512R1
...
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-09-20 10:03:24 +01:00
Manuel Pégourié-Gonnard
7c7a3eaab5
Merge pull request #6290 from daverodgman/contributing_2.28
...
Clarify legal requirements for contributions
2022-09-16 09:02:06 +02:00
Dave Rodgman
769695eeb0
Clarify legal requirements for contributions
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2022-09-15 19:07:10 +01:00
Dave Rodgman
1963d67ed0
Merge pull request #6276 from daverodgman/fixcopyright_2.28
...
Backport 2.28: Correct copyright and license in crypto_spe.h
2022-09-13 11:24:01 +01:00
Dave Rodgman
e3619d06c2
Correct copyright and license in crypto_spe.h
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2022-09-12 17:58:29 +01:00
Manuel Pégourié-Gonnard
1b36e1b4d7
Merge pull request #6246 from superna9999/6100-crash-in-test-suite-x509write-backport
...
[Backport 2.28]Crash in test suite x509write config full no seedfile
2022-09-01 11:18:41 +02:00
Neil Armstrong
11048661a5
Initialize mbedtls_x509write_csr struct before USE_PSA_INIT(), mbedtls_x509write_csr_free() will crash if uninitialized
...
When USE_PSA_INIT() failed because lack of seedfile, mbedtls_x509write_csr_free()
crashed when called on an unitialized mbedtls_x509write_csr struct.
This moves mbedtls_x509write_csr_init before calling USE_PSA_INIT(),
which could probably fail, and uses the same flow in x509_csr_check()
and x509_csr_check_opaque().
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com >
2022-08-30 15:56:40 +02:00
Werner Lewis
505a05073c
Use spec values as-is for test data
...
Spec values are now always used for test data, and conversion to
internal representation is done in the test function.
Signed-off-by: Werner Lewis <werner.lewis@arm.com >
2022-08-25 14:05:23 +01:00
Gilles Peskine
250a612969
Merge pull request #6212 from tom-cosgrove-arm/explicit-warning-re-ct-conditions-not-0-or-1-2.28
...
Backport 2.28: Be explicit about constant time bignum functions that must take a 0 or 1 condition value
2022-08-22 17:24:10 +02:00
Dave Rodgman
906bdbb66e
Merge pull request #6215 from daverodgman/pr6185-backport
...
Backprort: ssl_tls12_server: fix potential NULL-dereferencing
2022-08-19 20:22:36 +01:00
Leonid Rozenboim
81e742333e
ssl_tls12_server: fix potential NULL-dereferencing if local certificate was not set.
...
Signed-off-by: Leonid Rozenboim <leonid.rozenboim@oracle.com >
2022-08-19 13:42:08 +01:00
Tom Cosgrove
f211d824d7
Be explicit about constant time bignum functions that must take a 0 or 1 condition value
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2022-08-18 14:56:00 +01:00
Dave Rodgman
928527cba9
Merge pull request #5990 from zhangsenWang/mbedtls-2.28
...
Backport 2.28: Re-enable 5 tests disabled because of an old OpenSSL bug
2022-08-16 09:56:52 +01:00