Tom Cosgrove
17526a0d16
Merge pull request #7906 from yanrayw/add-pake_guards_psa_crypto
...
PSA: add guards for PAKE getter functions
2023-07-24 15:59:28 +01:00
Waleed Elmelegy
f3fafc3645
Fix CI errors related pkcs5_pbe changes
...
Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com >
2023-07-24 11:45:46 +01:00
Yanray Wang
f2cd717952
code_size_compare: print 'None' if comparing size for a new file
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:15 +08:00
Yanray Wang
69262fc087
code_size_compare: add extra indication if print to sys.stdout
...
If we output comparison result into sys.stdout, it will print an
extra line to show information we used for code size comparison in
detail. This would be helpful if we copy & paste code size changes
in Github comment.
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:15 +08:00
Yanray Wang
a6cf692e2a
code_size_compare: simplify how to generate file name of code size
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:15 +08:00
Yanray Wang
950590099d
code_size_compare: simplify CodeSizeGeneratorWithSize
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:15 +08:00
Yanray Wang
5605c6f58f
code_size_compare: make CodeSizeBuildInfo more flexible
...
This commit changes how to infer make command. Although we haven't
supported to pass more options in command line, this is the
preparation work to support those features.
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:15 +08:00
Yanray Wang
955671b0ef
code_size_compare: replace SimpleNameSpace to a clearer data struct
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:15 +08:00
Yanray Wang
5b64e4c7e0
code_size_compare: clean up comments
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:15 +08:00
Yanray Wang
386c2f9e93
code_size_compare: clean up code to make it more readable
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:15 +08:00
Yanray Wang
21127f7095
code_size_compare: add logging module and tweak prompt message
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 18:07:12 +08:00
Agathiyan Bragadeesh
8dc913899d
Fix server1.crt.der in makefile
...
Signed-off-by: Agathiyan Bragadeesh <agathiyan.bragadeesh2@arm.com >
2023-07-24 10:44:00 +01:00
Yanray Wang
227576aaa4
code_size_compare: add option --stdout to show result in sys.stdout
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Yanray Wang
b664cb7569
code_size_compare: add --markdown to show result in a markdown table
...
The option --markdown supports to only show the files that
have changed in a markdown table between two commits.
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Yanray Wang
9b174e90d3
code_size_compare: generate text,data as comparison result
...
Previously we used dec(total) as comparison result of code size
measurement. However, it's not accurate because dec(total) is
the sum of text, data and bss. Now we show text,data instead
since those are sections we care about in code size perspective
specifically for TF-M.
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Yanray Wang
802af160b4
code_size_compare: support to measure code size with multiple tools
...
For time being, code_size_compare.py only supports `size`. This
commit builds up foundation to extend code size measurement with
other tools.
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Yanray Wang
923f943a3e
code_size_compare: introduce SimpleNamespace to store info
...
We use SimpleNamespace class to store all the information used to
measure code size of objects in library.
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Yanray Wang
5e9130a5e9
code_size_compare: simplify methods in CodeSizeComparison
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Yanray Wang
e0e276046b
code_size_compare: add CodeSizeCalculator to calculate code size
...
CodeSizeCalculator is aimed to calculate code size based on a Git
revision and code size measurement tool. The output of code size is
in utf-8 encoding.
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Yanray Wang
15c43f3407
code_size_compare: add a base class as CodeSizeGenerator
...
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Yanray Wang
fc6ed4ddad
code_size_compare: add a parser to generate code size with size tool
...
This commit splits CodeSizeBase as a separate class to prepare a
parser as CodeSizeGenerator. The benefit is we can extend the tool
of code size measurement in order to generate more types of code
size record.
Signed-off-by: Yanray Wang <yanray.wang@arm.com >
2023-07-24 16:44:50 +08:00
Agathiyan Bragadeesh
3dd3ae219e
Remove trailing backslash
...
Signed-off-by: Agathiyan Bragadeesh <agathiyan.bragadeesh2@arm.com >
2023-07-21 17:07:00 +01:00
Gilles Peskine
5647d06be8
Merge pull request #7518 from gilles-peskine-arm/psa_inject_entropy-file-stability
...
Fix and test MBEDTLS_PSA_INJECT_ENTROPY
2023-07-21 17:37:15 +02:00
Gilles Peskine
2387bdab0f
Merge pull request #1038 from Mbed-TLS/development
...
Merge development into development-restricted
2023-07-21 15:40:36 +02:00
Tom Cosgrove
e4e9e7da58
For tests, rename TEST_BUFFERS_EQUAL() to TEST_MEMORY_COMPARE()
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2023-07-21 11:45:25 +01:00
Tom Cosgrove
a45d902822
Rename the length argument to TEST_CALLOC() to be the more accurate item_count
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2023-07-21 11:36:11 +01:00
Tom Cosgrove
05b2a87ea0
For tests, rename TEST_CALLOC_OR_FAIL() to just TEST_CALLOC()
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2023-07-21 11:32:25 +01:00
Ronald Cron
87f62850f3
Merge pull request #7893 from ronald-cron-arm/misc-from-psa-crypto
...
Miscellaneous fixes resulting from the work on PSA-Crypto
2023-07-21 10:54:41 +02:00
Xiaokang Qian
c495845e7a
Align ECP_MPI_INIT with mbedtls_mpi struct order in ecp_new.c
...
Signed-off-by: Xiaokang Qian <xiaokang.qian@arm.com >
2023-07-21 08:22:13 +00:00
Xiaokang Qian
73d98405b8
Rework the clone of ecp_curves.c
...
Change macro guard
rebase ecp_curves_new.c to the latest ecp_curves.c
Signed-off-by: Xiaokang Qian <xiaokang.qian@arm.com >
2023-07-21 08:22:12 +00:00
Xiaokang Qian
4d71051145
Enable build of ecp_curves_new.c
...
Signed-off-by: Xiaokang Qian <xiaokang.qian@arm.com >
2023-07-21 08:22:12 +00:00
Xiaokang Qian
dc2ea2705b
Clone the ecp_curve.c file as ecp_curve_new.c
...
Use macro guard MBEDTLS_ECP_WITH_MPI_UINT/STRUCT to enable
either c file
Signed-off-by: Xiaokang Qian <xiaokang.qian@arm.com >
2023-07-21 08:22:11 +00:00
Tom Cosgrove
412a813ad4
For tests, rename ASSERT_ALLOC_WEAK() to TEST_CALLOC_OR_SKIP()
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2023-07-20 16:55:14 +01:00
Gilles Peskine
c723e86e56
Fix copypasta in function documentation
...
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2023-07-20 17:54:19 +02:00
Tom Cosgrove
f9ffd11e7a
For tests, rename ASSERT_ALLOC() to TEST_CALLOC_OR_FAIL()
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2023-07-20 16:51:21 +01:00
Tom Cosgrove
65cd8519f7
For tests, rename ASSERT_COMPARE() to TEST_BUFFERS_EQUAL()
...
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com >
2023-07-20 16:51:15 +01:00
Dave Rodgman
ed70fd0c39
Merge pull request #5549 from AndrzejKurek/doxygen-bad-param-names
...
Fix wrong doxygen parameter names and misused `\p` commands
2023-07-20 14:10:10 +01:00
Manuel Pégourié-Gonnard
c844c1a771
Merge pull request #7546 from mpg/align-psa-md-identifiers
...
Align psa md identifiers
2023-07-20 11:34:28 +02:00
Ronald Cron
7612d8c049
all.sh: Use consistently CONFIG_TEST_DRIVER_H
...
Signed-off-by: Ronald Cron <ronald.cron@arm.com >
2023-07-20 10:20:55 +02:00
Ronald Cron
6b49b55d6d
all.sh: Use consistently CRYPTO_CONFIG_H
...
Signed-off-by: Ronald Cron <ronald.cron@arm.com >
2023-07-20 10:02:59 +02:00
Ronald Cron
7a93ac5308
all.sh: Use consistently CONFIG_H
...
Signed-off-by: Ronald Cron <ronald.cron@arm.com >
2023-07-20 10:02:32 +02:00
Ronald Cron
2b25d36165
Fix PSA crypto configuration file name
...
Signed-off-by: Ronald Cron <ronald.cron@arm.com >
2023-07-20 09:09:10 +02:00
Dave Rodgman
7fa27a1a18
Merge pull request #7960 from daverodgman/expect-fix
2023-07-19 19:48:15 +01:00
Dave Rodgman
e9fcffd089
Robustness fix to MBEDTLS_LIKELY
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2023-07-19 15:43:07 +01:00
Dave Rodgman
8e8e6b9be3
Merge pull request #7934 from AgathiyanB/move-declarations-to-top
...
Move declarations to top of functions
2023-07-19 15:25:27 +01:00
Dave Rodgman
6dd40642e8
Merge pull request #7932 from AgathiyanB/add-mpi-uint-size-macro
...
Use compile-time determination of which __builtin_clz() to use, with new MBEDTLS_MPI_UINT_SIZE macro
2023-07-19 14:57:39 +01:00
Waleed Elmelegy
708d78f80b
Improve & test legacy mbedtls_pkcs5_pbe2
...
* Prevent pkcs5_pbe2 encryption when PKCS7 padding has been
disabled since this not part of the specs.
* Allow decryption when PKCS7 padding is disabled for legacy
reasons, However, invalid padding is not checked.
* Add tests to check these scenarios. Test data has been
reused but with changing padding data in last block to
check for valid/invalid padding.
* Document new behaviour, known limitations and possible
security concerns.
Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com >
2023-07-19 14:01:35 +01:00
Agathiyan Bragadeesh
eed55c6c94
Use defined macros for MBEDTLS_MPI_UINT_MAX
...
Signed-off-by: Agathiyan Bragadeesh <agathiyan.bragadeesh2@arm.com >
2023-07-19 11:08:02 +01:00
Dave Rodgman
9e8104cdd9
Merge pull request #7949 from AgathiyanB/IAR-asm-keyword
...
Use correct asm keyword for IAR compilers
2023-07-19 10:03:30 +01:00
Dave Rodgman
131a22ef27
Merge pull request #7950 from AgathiyanB/fix-IAR-using-memset-s
...
Fix IAR trying to use memset_s in platform_util
2023-07-19 10:01:58 +01:00