1a0a4d60d9
Implement new strategy for ECC accel/built-in
...
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2023-09-25 17:39:41 +02:00
0d99271d14
Group all ECC-related things in legacy_from_psa.h
...
Just moving things, no change.
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2023-09-25 17:39:41 +02:00
bfc6ef7a5c
Improve PSA config adjustment relate to keypair types
...
Centralize it in a new file psa/config_adjust_keypair_types.h. I think
this file indeed belongs in include/psa (as opposed to include/mbedtls)
because it only touches PSA_WANT symbols (no MBEDTLS_PSA symbols), and
implements things that are described in psa-conditional-inclusion.md.
The code is not new, just moved from config_psa.h and
config_adjust_legacy_from_psa.h where is was intermingled with handling
of ACCEL/BUILTIN symbols. (git's --color-moved option will hardly help
in checking that assertion, due to the way things were intermixed.)
Note: the parts about BUILTIN in config_psa.h were not moved, just
removed for now. They belong to
include/mbedtls/config_adjust_legacy_from_psa.h and will be
re-added there in a future commit which will completely re-organize the
handling or ACCEL/BUILTIN for ECC.
See comments inside the commit about placement of this file relative to
others.
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2023-09-25 17:39:41 +02:00
7af9d07c05
Remove unnecessary block
...
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2023-09-25 17:39:41 +02:00
c437faeaa1
psa_crypto: fix guards in mbedtls_ecc_group_to_psa()
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
bf206b8f41
adjust_legacy_from_psa: undef SOME_BUILTIN_EC when builtin curves are used
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
19d92108c1
config_psa: resolve symbol redefinition issue
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
4ca250b873
test: fix comment
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
ea167c39d0
check_config: remove unnecessary check about builtin curve usage
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
bbf86afdeb
test_suite_psa_crypto: fix curve dependency in test
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
db6b4db7a0
Renaming all MBEDTLS_HAVE for curves to MBEDTLS_ECP_HAVE
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
0a342c9512
test: fix comments and functions' naming
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
cf29c5d9d5
ssl: don't require MBEDTLS_ECP_DP with TLS1.3
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
b2219f633d
config_psa: moving PSA_WANT auto-enabling code
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
e6f65a951f
config_psa: fix comment
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
482a0b957f
test: fix remaining disparities and remove debug leftovers
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
872462dfa9
test: fix test accelerating all curves keeping only 1 builtin
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
6d809cc969
lib/test: use new internal helpers in library's code and tests
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
67d82e742b
build_info: add helpers to signal some support for a specific curve
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:41 +02:00
4b75a764c7
check_config: include also ECJPAKE_C as usage for builtin curves
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
f250ada3ab
tls/oid: add PSA_WANT_ECC_xxx guards together with existing MBEDTLS_ECP_DP_xxx
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
b2fd673ec8
test: fix test which are using accelerated ECC/DH keys
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
dca8492043
check_config: request at least 1 builtin EC alg if there is at least 1 builtin curve
...
This slightly changes the previous requirement. Instead of enabling
ALL builtin EC algs when there is at least 1 built in curve, we ask
for at least one built alg if there is at least one builtin curve.
This relaxes the previous check while still keeping the base idea:
there must be a reason for which builtin curves are included into
the build.
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
29837c7301
config_psa: include builtin algs if there is at least 1 builtin curve
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
9aed893fb0
config_psa: check curves' support before EC ALGs
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
d6b473adcd
config_psa: add internal helper to signal that some curve is builtin
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
87076abbfb
config_psa: ensure PSA_WANT_ECC is enabled for each MBEDTLS_ECP_DP
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
8ec212098e
check_config: fix comment
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
8600de818c
check_config: perform checks only when config_psa.h is evaluated
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
3b69e3ed12
check_config: skip check on SECP224K1 because the PSA is never enabled
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
a7a18313a6
check_config: verify that each ECP_DP has the corresponding PSA_WANT_ECC
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no >
2023-09-25 17:39:40 +02:00
ffe590d197
Merge pull request #1058 from waleed-elmelegy-arm/check-set_padding-is-called
...
Check set_padding has been called in mbedtls_cipher_finish
2023-09-25 17:12:36 +02:00
21087754a5
x509_crt: Removed unused intsafe.h
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 15:17:38 +01:00
ca1e605b9c
Merge remote-tracking branch 'upstream-public/development' into development-restricted-merge-20230925
...
Conflicts:
* `include/mbedtls/build_info.h`: a new fragment to auto-enable
`MBEDTLS_CIPHER_PADDING_PKCS7` was added in
c9f4040f7f
in `development-restricted`.
In `development`, this section of the file has moved to
`include/mbedtls/config_adjust_legacy_crypto.h`.
* `library/bignum.c`: function name change in `development-restricted` vs
comment change in development. The comment change in `development` is not
really relevant, so just take the line from `development-restricted`.
2023-09-25 16:16:26 +02:00
a9bb34cd73
x509_crt: Removed length_as_int intermediate variable
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:42:41 +01:00
59108d3f4d
x509_crt: Adjusted the len of lpMultiByteStr arg in WideCharToMultiByte
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:23 +01:00
08a67ccefd
x509_crt: Set WideCharToMultiByte to use -1 for length.
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
WideCharToMultiByte
2023-09-25 14:12:23 +01:00
b17410d975
vs2013 templates: Set bcrypt to be the sole dependency.
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
40995e1390
x509_crt: Removed checks for windows versions < WINXP
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
fac45fbafe
entropy_poll: Removed checks for windows versions < WINXP
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
c91d847e0d
ChangeLog: Adjusted the updated_windows_apis log
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
a8b02ef79b
pkey-random: Removed setting mbedtls_target in libs
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
e8a5d1afbd
entropy_poll: Updated documentation for entropy_poll loop.
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
7f8e8c5ae2
program-random: Updated Cmake libs variable
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
ce33e7b22d
pkey Cmakelists: Updated the set libs to be consistent with others.
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
2c6e561ff8
entropy_poll.c: Added looping logic to mbedtls_platform_entropy_poll()
.
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
7afebccf69
ChangeLog.d: Added mininum required Windows version.
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
4952f705ee
Removed unsupported Visual Studio related code in entropy_poll.c and x509_crt.c.
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
e960365957
ChangeLog.d: Reworded updated_windows_apis.txt.
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:22 +01:00
8792717309
Changelog: Removed entry from root file
...
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2023-09-25 14:12:21 +01:00