37d41c79b8
Add ChangeLog entry for DTLS Connection ID
...
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2022-11-29 10:20:15 +01:00
ffc330fafa
Merge pull request #6264 from hannestschofenig/rfc9146_2
...
CID update to RFC 9146
2022-11-29 09:25:14 +01:00
66f09834ea
Enable optimisation with Asan with make in all.sh
...
All builds using ASAN_CFLAGS were with Asan but no optimisation, making
them particularly slow. Indeed, we were overwriting CFLAGS which
defaults to -O2 and not using any -O in the replacement. (CMake already has
optimisations on with ASan.)
While at it, also remove -Wall -Wextra which are redundant as they are
already part of WARNING_CFLAGS which we are not overwriting.
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com >
2022-11-29 09:12:12 +01:00
aec08b3f42
fix various format issues
...
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-29 15:19:27 +08:00
a13f5eb7b8
Add missing dependency for the fuzzer-constructed test data
...
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-28 21:30:04 +01:00
97915c8685
Merge pull request #6619 from minosgalanakis/bignum/add_high_lv_IO_methods
...
Bignum: Adding High level I/O methods
2022-11-28 17:27:48 +00:00
a9a97dca63
psa_pake: add support for opaque password
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-11-28 18:26:16 +01:00
6d23ff60dd
Make use of optimised bswap from bignum
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2022-11-28 15:41:13 +00:00
f7f1f748e3
Support built-in byteswap routines from clang, gcc, MSVC
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2022-11-28 15:41:13 +00:00
a5110b0d79
Make use of efficient unaligned access functions
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2022-11-28 15:41:13 +00:00
6298b24127
Add byteswap routines
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2022-11-28 15:41:13 +00:00
e5c42594e5
Add byte order detection macro
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2022-11-28 15:41:13 +00:00
a360e1987a
Add efficent unaligned get/put functions
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com >
2022-11-28 15:41:04 +00:00
d98ac8b75e
Merge remote-tracking branch 'dave/fast_xor' into fast_unaligned
2022-11-28 15:06:25 +00:00
1f8afa22a4
Bignum Mod: improve documentation and style
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-28 14:58:08 +00:00
1ac41dec09
Add test function for opaque driver (simply returns PSA_ERROR_NOT_SUPPORTED), and address other review comments.
...
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com >
2022-11-28 14:46:30 +00:00
095c4756ee
Merge pull request #6674 from AndrzejKurek/ecjpake-changelog
...
Add a changelog entry explaining usage of PSA in TLS 1.2 EC J-PAKE
2022-11-28 12:44:38 +01:00
a34d0308cc
test: psa_pake: fix dependency
...
Signed-off-by: Valerio Setti <vsetti@baylibre.com >
2022-11-28 11:46:36 +01:00
84bee4c492
mbedtls_mpi_mod_write: improve readability
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-28 10:27:14 +00:00
3861062f6b
Tell cmake to get SKIP_TEST_SUITES from ENV
...
If the variable SKIP_TEST_SUITES is not defined with -D, but is defined
in an environment variable, tell cmake to get it from there.
Signed-off-by: David Horstmann <david.horstmann@arm.com >
2022-11-28 10:18:05 +00:00
3d78e08ac0
erase early secrets and transcripts
...
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
a5db6c0ce3
fix coding style issues.
...
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
e31688b7fa
fix comments issue
...
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
a8771839e8
Refactor make_traffic_keys
...
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
3ce61ffca6
fix comments and function name issues
...
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
b094e124f2
fix various issues
...
- Alignments
- comment words in doxygen paragraph
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
91b560f38d
Add compute early transform
...
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
3d9b590f02
guards transform_earlydata
...
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
84a6edac10
change signature of get_cipher_key_info
...
- it is a static function. The name is not follow nameing ruler
- move the position.
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com >
2022-11-28 17:34:06 +08:00
a6ab9d8b12
Add a changelog entry explaining usage of PSA in TLS 1.2 EC J-PAKE
...
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com >
2022-11-28 03:55:27 -05:00
13256ba65c
Merge pull request #6667 from gilles-peskine-arm/lib-crypto-modules-202211
...
Move SSL modules out of libmbedcrypto
2022-11-28 08:51:49 +01:00
4f01121f6e
Fix memory leak on error in pkcs7_get_signers_info_set
...
mbedtls_x509_name allocates memory, which must be freed if there is a
subsequent error.
Credit to OSS-Fuzz (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=53811 ).
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-27 22:02:10 +01:00
e7f8c616d0
Fix dangling freed pointer in pkcs7_free_signer_info
...
This may have been a use-after-free, but I haven't worked out whether it was
a problem or not. Even if it turns out to have been ok, keeping invalid
pointers around is fragile.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-27 21:55:29 +01:00
47a732635b
Simplify control flow in PKCS7 functions
...
Remove useless goto in several functions.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-27 21:55:29 +01:00
391005cb3b
Fix structures initialized too late in tests
...
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-27 21:55:29 +01:00
2336555444
Improve test failure reporting
...
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-27 21:55:29 +01:00
290f01b3f5
Fix dangling freed pointer on error in pkcs7_get_signers_info_set
...
This fixes a use-after-free in PKCS#7 parsing when the signer data is
malformed.
Credit to OSS-Fuzz (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=53798 ).
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-27 21:55:29 +01:00
e7190a2960
mpi_mod_io_neg: fix use of uninitialized value
...
Uninitialized values are invalid for the tested functions and we
shouldn't be testing that.
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 18:46:54 +00:00
6eb92c0410
Bignum Mod: improve documentation and style
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 17:34:37 +00:00
0020df9cf9
mpi_mod_io: test with various buffer sizes
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 17:23:16 +00:00
8dfc8c41b7
mbedtls_mpi_mod_write: prevent data corruption
...
The function wasn't converting back data to internal representation when
writing it out.
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 15:39:02 +00:00
d7bb35257b
mbedtls_mpi_mod_read/write: restrict pre-conditions
...
Require equality for the number of limbs in the modulus and the residue.
This makes these functions consistent with residue_setup().
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 14:59:27 +00:00
75b9f0fd2e
mbedtls_mpi_mod_read/write: remove redundant checks
...
The function isn't documented as accepting null pointer, and there's no
reason why it should be. Just let it dereference the pointer.
The null/zero checks are only marginally useful: they validate that m
and r are properly populated objects, not freshly initialized ones. For
that, it's enough to check that the pointers aren't null or that the
sizes aren't zero, we don't need to check both.
Also, use separate if statements for unrelated checks.
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 14:28:50 +00:00
6ef582f2b8
Bignum Mod Tests: improve readabilty and style
...
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 14:19:02 +00:00
89e31adbee
Move mps modules to the correct library
...
This is a private interface only, so it's an ABI change but not an API change.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-26 14:18:45 +01:00
898db6b8e5
Move ssl_debug_helpers_generated to the correct library
...
This is a private interface only, so it's an ABI change but not an API change.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com >
2022-11-26 14:15:32 +01:00
339b439906
Bignum Mod: remove unused parameter in io_neg test
...
The value was overwritten and the length wasn't used either. This latter
could have lead to a buffer overflow as well.
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 12:24:34 +00:00
566c91db27
Bignum Mod: io_neg test pass data directly
...
Pass buffer directly instead of constructing it in the function.
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 12:24:34 +00:00
96070a53a8
bignum_tests: Refactored mpi_mod_io_neg()
...
This patch refactores the negative testing suite
to utilised non-hardcoded input data.
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com >
2022-11-26 12:24:34 +00:00
91f3abdfda
Bignum Mod: improve residue_setup test
...
- Rename input variables to match their purpose.
- Assert fields upon success
Signed-off-by: Janos Follath <janos.follath@arm.com >
2022-11-26 12:24:34 +00:00