lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-08-07 06:42:56 +03:00
Code Activity
17,369 Commits 174 Branches 272 Tags
archive/new-code-style/mbedtls-2.28
Commit Graph

56 Commits

Author SHA1 Message Date
Gilles Peskine
1b6c09a62e Switch to the new code style 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2023-01-11 14:52:35 +01:00
Przemek Stekiel
169554c68f Adapt macro names: MBEDTLS_SSL_SOME_SUITES_USE_MAC->MBEDTLS_SSL_SOME_MODES_USE_MAC 
Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>
 2022-10-06 10:53:20 +02:00
Przemek Stekiel
9450dc7b6f Fix guards for mbedtls_ct_size_mask() and mbedtls_ct_memcpy_if_eq() 
Both functions are used when MBEDTLS_SSL_SOME_SUITES_USE_MAC is defined not MBEDTLS_SSL_SOME_SUITES_USE_TLS_CBC.

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>
 2022-10-05 11:38:25 +02:00
Tom Cosgrove
f211d824d7 Be explicit about constant time bignum functions that must take a 0 or 1 condition value 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
 2022-08-18 14:56:00 +01:00
Paul Elliott
b830028314 Fix uninitialised memory access in constant time functions 
Fix an issue reported by Coverity whereby some constant time functions
called from the ssl decrypt code could potentially access uninitialised
memory.

Signed-off-by: Paul Elliott <paul.elliott@arm.com>
 2022-05-19 18:31:35 +01:00
Shaun Case
0e7791ff07 Redo of PR#5345. Fixed spelling and typographical errors found by CodeSpell. 
Signed-off-by: Shaun Case <warmsocks@gmail.com>
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-04-28 18:22:20 +01:00
Tautvydas Žilys
61156f8a6a Cap the workaround for mbedtls_mpi_safe_cond_assign on MSVC/ARM64 to MSVC versions prior to 17.1. 
Signed-off-by: Tautvydas Žilys <tautvydas.zilys@gmail.com>
 2022-01-31 13:37:47 -08:00
Tautvydas Žilys
ea4af4d345 Don't inline mbedtls_mpi_safe_cond_assign on MSVC/ARM64 to avoid a compiler bug. 
Signed-off-by: Tautvydas Žilys <tautvydas.zilys@gmail.com>
 2022-01-26 15:44:47 -08:00
Gabor Mezei
3a755f511f Add documentation for the functions 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-12-08 16:24:22 +01:00
Gabor Mezei
46ca2f76c4 Unify function parameters 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-12-08 16:22:45 +01:00
Gabor Mezei
df29332d4b Make mbedtls_ct_uchar_mask_of_range function static 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-12-08 16:20:39 +01:00
Gabor Mezei
3d4dba84b7 Move mbedtls_ct_base64_dec_value function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-12-08 16:20:16 +01:00
Gabor Mezei
200708d30a Move mbedtls_ct_base64_enc_char function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-12-08 16:20:04 +01:00
Gabor Mezei
46f79c388d Move mbedtls_ct_uchar_mask_of_range function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-12-08 16:19:41 +01:00
Gabor Mezei
dbe0f892b3 Fix documentation and comments 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:33:19 +01:00
Gabor Mezei
c0ae1cf45a Rename internal header constant_time.h to constant_time_internal.h 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:33:19 +01:00
Gabor Mezei
18a44949d0 Rename constant-time functions to have mbedtls_ct prefix 
Rename functions to better suite with the module name.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:32:01 +01:00
Gabor Mezei
61bf64fbd0 Bind functions' availability for config options 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:54 +01:00
Gabor Mezei
e24dea8225 Move mbedtls_cf_memcmp to a new public header 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:54 +01:00
Gabor Mezei
2b35880d41 Bind functions' availability for config options 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:53 +01:00
Gabor Mezei
4e2de62fef Remove unused function 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:53 +01:00
Gabor Mezei
fd8a42d914 Make functions static 
These functions are only used as an auxiliary function for constant-time functions.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:53 +01:00
Gabor Mezei
4b4e4d8880 Update documentation and comments 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:53 +01:00
Gabor Mezei
91deea7765 Rename and reorder function parameters 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:53 +01:00
Gabor Mezei
150bdee126 Use condition for not sensitive data 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:53 +01:00
Gabor Mezei
3c38b6e9e1 Move implementation specific comment 
This comment is about how the functions are implemented, not about their
public interface, so it doesn't belong in the header file.
It applies to everything in constant_time.c so moved there.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:52 +01:00
Gabor Mezei
2c5ed2244b Make mbedtls_cf_size_mask_lt function static 
The mbedtls_cf_size_mask_lt is solely used as an auxiliary function
for mbedtls_cf_size_mask_ge.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:52 +01:00
gabor-mezei-arm
d5a392aa2c Fix missing includes 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:52 +01:00
gabor-mezei-arm
7e6a1eaf8f Add documentation for the functions 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:52 +01:00
gabor-mezei-arm
1ffd0ccf02 Unify equality checker functions return value 
The equality checker functions always return 0 or 1 value,
thus the type of return value can be the same dispite of the
size of the parameters.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:52 +01:00
gabor-mezei-arm
60febd5d8a Propagate usage of mask generation functions 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:52 +01:00
gabor-mezei-arm
2f2c0bead3 Unify mask generation functions 
Generate all-bits 0 or all bits 1 mask from a value instead of from a bit.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:51 +01:00
gabor-mezei-arm
5e4882498e Unify function parameters 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:51 +01:00
gabor-mezei-arm
378e7eb5cc Unify memcmp functions 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:51 +01:00
gabor-mezei-arm
04087dffcd Typo: Unify indentation of function parameters 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:51 +01:00
gabor-mezei-arm
f52941ef73 Move mbedtls_cf_rsaes_pkcs1_v15_unpadding function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:04:51 +01:00
gabor-mezei-arm
bc3a288b2c Create mbedtls_cf_size_if function 
Add a constant-time function with size_t parameter for choosing
between two integer values, like the ?: ternary operator.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:03:04 +01:00
gabor-mezei-arm
b10301d2fc Move mbedtls_mpi_lt_mpi_ct function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:02:38 +01:00
gabor-mezei-arm
58fc8a65ab Move mbedtls_mpi_safe_cond_swap function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:01:08 +01:00
gabor-mezei-arm
b8caeeed5c Move mbedtls_mpi_safe_cond_assign function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 11:00:14 +01:00
gabor-mezei-arm
cb4317b723 Move mbedtls_cf_hmac function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:59:04 +01:00
gabor-mezei-arm
0f7b9e43e9 Move mbedtls_cf_memcpy_offset function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:59:04 +01:00
gabor-mezei-arm
ee06febbb4 Move mbedtls_cf_memcpy_if_eq function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:59:04 +01:00
gabor-mezei-arm
7b23c0b46d Move mbedtls_cf_mem_move_to_left function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:59:04 +01:00
gabor-mezei-arm
043192d209 Move mbedtls_cf_mpi_uint_cond_assign function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:55:56 +01:00
gabor-mezei-arm
5cec8b44a8 Move mbedtls_cf_cond_select_sign function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:54:20 +01:00
gabor-mezei-arm
7533253125 Move mbedtls_cf_uint_if function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:52:42 +01:00
gabor-mezei-arm
097d4f555e Move mbedtls_cf_mpi_uint_lt function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:52:01 +01:00
gabor-mezei-arm
9d7bf09333 Move mbedtls_cf_size_gt function to the constant-time module 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:04:49 +01:00
gabor-mezei-arm
96584ddd4b Move mbedtls_cf_size_bool_eq function to the constant-time module 
There were multiple functions called mbedtls_cf_size_bool_eq. They had exactly
the same behavior, so move the one in bignum.c and remove the other.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2021-11-11 10:03:55 +01:00