lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-11-03 20:33:16 +03:00
Code Activity

Check for len == 0 rather than buffer == NULL

Browse Source 
This makes the intention clearer

Signed-off-by: David Horstmann <david.horstmann@arm.com>
This commit is contained in:
David Horstmann
2023-11-16 20:26:16 +00:00
parent c3be8cb24a
commit d79d5e7ed0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/suites/test_suite_psa_crypto_memory.function
View File

@@ -94,7 +94,7 @@ void input_copy_alloc(int input_len, psa_status_t exp_status)
TEST_EQUAL(status, exp_status); TEST_EQUAL(status, exp_status);
if (exp_status == PSA_SUCCESS) { if (exp_status == PSA_SUCCESS) {
if (input == NULL) { if (input_len == 0) {
TEST_ASSERT(input_copy.buffer == NULL); TEST_ASSERT(input_copy.buffer == NULL);
} else { } else {
TEST_ASSERT(input_copy.buffer != input); TEST_ASSERT(input_copy.buffer != input);
@@ -167,7 +167,7 @@ void output_copy_alloc(int output_len, psa_status_t exp_status)
if (exp_status == PSA_SUCCESS) { if (exp_status == PSA_SUCCESS) {
TEST_ASSERT(output_copy.original == output); TEST_ASSERT(output_copy.original == output);
if (output == NULL) { if (output_len == 0) {
TEST_ASSERT(output_copy.buffer == NULL); TEST_ASSERT(output_copy.buffer == NULL);
} }
TEST_EQUAL(output_copy.len, output_len); TEST_EQUAL(output_copy.len, output_len);
@@ -203,7 +203,7 @@ void output_copy_free(int output_len, int original_is_null,
output_copy.len = output_len; output_copy.len = output_len;
output_copy.original = output; output_copy.original = output;
if (output_copy.buffer != NULL) { if (output_copy.len != 0) {
fill_buffer_pattern(output_copy.buffer, output_copy.len); fill_buffer_pattern(output_copy.buffer, output_copy.len);
memcpy(buffer_copy_for_comparison, output_copy.buffer, output_copy.len); memcpy(buffer_copy_for_comparison, output_copy.buffer, output_copy.len);
} }