lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-07-29 11:41:15 +03:00
Code Activity

Merge pull request #3611 from gilles-peskine-arm/psa-coverity-cleanups-202008

Browse Source 
Minor fixes in PSA code and tests
This commit is contained in:
Gilles Peskine
2020-08-26 13:18:27 +02:00
committed by GitHub
parent 9e4d4387f0 a2e518daf5
commit d4b9133850
7 changed files with 63 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
library/psa_crypto_storage.c
View File

@ -174,7 +174,13 @@ static psa_status_t psa_crypto_storage_store( const psa_key_file_id_t key,
exit:
if( status != PSA_SUCCESS )
psa_its_remove( data_identifier );
{
/* Remove the file in case we managed to create it but something
* went wrong. It's ok if the file doesn't exist. If the file exists
* but the removal fails, we're already reporting an error so there's
* nothing else we can do. */
(void) psa_its_remove( data_identifier );
}
return( status );
}

7
library/psa_its_file.c
View File

@ -233,7 +233,12 @@ exit:
if( rename_replace_existing( PSA_ITS_STORAGE_TEMP, filename ) != 0 )
status = PSA_ERROR_STORAGE_FAILURE;
}
remove( PSA_ITS_STORAGE_TEMP );
/* The temporary file may still exist, but only in failure cases where
* we're already reporting an error. So there's nothing we can do on
* failure. If the function succeeded, and in some error cases, the
* temporary file doesn't exist and so remove() is expected to fail.
* Thus we just ignore the return status of remove(). */
(void) remove( PSA_ITS_STORAGE_TEMP );
return( status );
}