lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-10-28 23:14:56 +03:00
Code Activity

Fix memory leak in mbedtls_mpi_sub_abs

Browse Source 
Fix a memory leak in mbedtls_mpi_sub_abs when the output parameter is
aliased to the second operand (X = A - X) and the result is negative.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
Gilles Peskine
2020-07-23 01:16:46 +02:00
parent 56f943a184
commit 89b4130098
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
library/bignum.c
View File

@@ -1411,7 +1411,10 @@ int mbedtls_mpi_sub_abs( mbedtls_mpi *X, const mbedtls_mpi *A, const mbedtls_mpi
/* If we ran out of space for the carry, it means that the result /* If we ran out of space for the carry, it means that the result
* is negative. */ * is negative. */
if( n == X->n ) if( n == X->n )
return( MBEDTLS_ERR_MPI_NEGATIVE_VALUE ); {
ret = MBEDTLS_ERR_MPI_NEGATIVE_VALUE;
goto cleanup;
}
--X->p[n]; --X->p[n];
} }