lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-08-08 17:42:09 +03:00
Code Activity

analyze_oucomes: do not return Results instance passed as parameter

Browse Source 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
This commit is contained in:
Valerio Setti
2023-10-17 12:47:35 +02:00
parent 8070dbec6b
commit 781c23416e
1 changed files with 12 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/scripts/analyze_outcomes.py
View File

@@ -57,7 +57,7 @@ class TestCaseOutcomes:
return len(self.successes) + len(self.failures) return len(self.successes) + len(self.failures)
def execute_reference_driver_tests(results: Results, ref_component, driver_component, \ def execute_reference_driver_tests(results: Results, ref_component, driver_component, \
outcome_file) -> Results: outcome_file):
"""Run the tests specified in ref_component and driver_component. Results """Run the tests specified in ref_component and driver_component. Results
are stored in the output_file and they will be used for the following are stored in the output_file and they will be used for the following
coverage analysis""" coverage analysis"""
@@ -66,7 +66,7 @@ def execute_reference_driver_tests(results: Results, ref_component, driver_compo
if os.path.exists(outcome_file): if os.path.exists(outcome_file):
results.info("Outcome file (" + outcome_file + ") already exists. " + \ results.info("Outcome file (" + outcome_file + ") already exists. " + \
"Tests will be skipped.") "Tests will be skipped.")
return results return
shell_command = "tests/scripts/all.sh --outcome-file " + outcome_file + \ shell_command = "tests/scripts/all.sh --outcome-file " + outcome_file + \
" " + ref_component + " " + driver_component " " + ref_component + " " + driver_component
@@ -76,8 +76,6 @@ def execute_reference_driver_tests(results: Results, ref_component, driver_compo
if ret_val != 0: if ret_val != 0:
results.error("failed to run reference/driver components") results.error("failed to run reference/driver components")
return results
def analyze_coverage(results, outcomes, allow_list, full_coverage): def analyze_coverage(results, outcomes, allow_list, full_coverage):
"""Check that all available test cases are executed at least once.""" """Check that all available test cases are executed at least once."""
available = check_test_cases.collect_available_test_cases() available = check_test_cases.collect_available_test_cases()
@@ -132,13 +130,10 @@ def analyze_driver_vs_reference(results: Results, outcomes,
if(reference_test_passed and not driver_test_passed): if(reference_test_passed and not driver_test_passed):
results.error(key) results.error(key)
return results def analyze_outcomes(results: Results, outcomes, args):
def analyze_outcomes(results: Results, outcomes, args) -> Results:
"""Run all analyses on the given outcome collection.""" """Run all analyses on the given outcome collection."""
analyze_coverage(results, outcomes, args['allow_list'], analyze_coverage(results, outcomes, args['allow_list'],
args['full_coverage']) args['full_coverage'])
return results
def read_outcome_file(outcome_file): def read_outcome_file(outcome_file):
"""Parse an outcome file and return an outcome collection. """Parse an outcome file and return an outcome collection.
@@ -161,30 +156,27 @@ by a semicolon.
outcomes[key].failures.append(setup) outcomes[key].failures.append(setup)
return outcomes return outcomes
def do_analyze_coverage(results: Results, outcome_file, args) -> Results: def do_analyze_coverage(results: Results, outcome_file, args):
"""Perform coverage analysis.""" """Perform coverage analysis."""
results.info("*** Analyze coverage ***") results.info("*** Analyze coverage ***")
outcomes = read_outcome_file(outcome_file) outcomes = read_outcome_file(outcome_file)
results = analyze_outcomes(results, outcomes, args) analyze_outcomes(results, outcomes, args)
return results
def do_analyze_driver_vs_reference(results: Results, outcome_file, args) -> Results: def do_analyze_driver_vs_reference(results: Results, outcome_file, args):
"""Perform driver vs reference analyze.""" """Perform driver vs reference analyze."""
results.info("*** Analyze driver {} vs reference {} ***".format( results.info("*** Analyze driver {} vs reference {} ***".format(
args['component_driver'], args['component_ref'])) args['component_driver'], args['component_ref']))
results = execute_reference_driver_tests(results, args['component_ref'], \ execute_reference_driver_tests(results, args['component_ref'], \
args['component_driver'], outcome_file) args['component_driver'], outcome_file)
ignored_suites = ['test_suite_' + x for x in args['ignored_suites']] ignored_suites = ['test_suite_' + x for x in args['ignored_suites']]
outcomes = read_outcome_file(outcome_file) outcomes = read_outcome_file(outcome_file)
results = analyze_driver_vs_reference(results, outcomes, analyze_driver_vs_reference(results, outcomes,
args['component_ref'], args['component_driver'], args['component_ref'], args['component_driver'],
ignored_suites, args['ignored_tests']) ignored_suites, args['ignored_tests'])
return results
# List of tasks with a function that can handle this task and additional arguments if required # List of tasks with a function that can handle this task and additional arguments if required
KNOWN_TASKS = { KNOWN_TASKS = {
@@ -688,7 +680,7 @@ def main():
for task in tasks_list: for task in tasks_list:
test_function = KNOWN_TASKS[task]['test_function'] test_function = KNOWN_TASKS[task]['test_function']
test_args = KNOWN_TASKS[task]['args'] test_args = KNOWN_TASKS[task]['args']
main_results = test_function(main_results, options.outcomes, test_args) test_function(main_results, options.outcomes, test_args)
main_results.info("Overall results: {} warnings and {} errors", main_results.info("Overall results: {} warnings and {} errors",
main_results.warning_count, main_results.error_count) main_results.warning_count, main_results.error_count)