lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-10-24 13:32:59 +03:00
Code Activity

Adjust mpi_gcd_modinv_odd docs and precondition checking

Browse Source 
Signed-off-by: Felix Conway <felix.conway@arm.com>
This commit is contained in:
Felix Conway
2025-08-04 11:34:19 +01:00
parent bd7ede3f33
commit 54a94c1598
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
library/bignum.c
View File

@@ -1763,7 +1763,7 @@ int mbedtls_mpi_gcd_modinv_odd(mbedtls_mpi *G,
} }
/* Check aliasing requirements */ /* Check aliasing requirements */
if (A == N || (I != NULL && (I == N || G == N))) { if (A == N || G == I || (I != NULL && (I == N || G == N))) {
return MBEDTLS_ERR_MPI_BAD_INPUT_DATA; return MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
} }

11
library/bignum_internal.h
View File

@@ -51,9 +51,14 @@ int mbedtls_mpi_exp_mod_unsafe(mbedtls_mpi *X, const mbedtls_mpi *A,
* \brief Compute GCD(A, N) and/or A^-1 mod N if it exists, * \brief Compute GCD(A, N) and/or A^-1 mod N if it exists,
* in constant time. * in constant time.
* *
* \warning Requires N to be odd, and 0 <= A <= N. * \warning Requires N to be odd, and 0 <= A <= N, and N > 1 if
* I != NULL.
* *
* \note G and I must not alias each other but may alias A or N. * \note G and I must not alias each other.
* A and N must not alias each other.
* When I == NULL (computing only the GCD), G can alias A or N.
* When I != NULL (computing the modular inverse), G or I can
* alias A, but neither of them can alias N (the modulus).
* *
* \param[out] G The GCD of \p A and \p N. * \param[out] G The GCD of \p A and \p N.
* This may be NULL, to only compute I. * This may be NULL, to only compute I.
@@ -67,6 +72,8 @@ int mbedtls_mpi_exp_mod_unsafe(mbedtls_mpi *X, const mbedtls_mpi *A,
* *
* \return \c 0 if successful. * \return \c 0 if successful.
* \return #MBEDTLS_ERR_MPI_ALLOC_FAILED if a memory allocation failed. * \return #MBEDTLS_ERR_MPI_ALLOC_FAILED if a memory allocation failed.
* \return #MBEDTLS_ERR_MPI_BAD_INPUT_DATA if preconditions were not
* met.
*/ */
int mbedtls_mpi_gcd_modinv_odd(mbedtls_mpi *G, int mbedtls_mpi_gcd_modinv_odd(mbedtls_mpi *G,
mbedtls_mpi *I, mbedtls_mpi *I,