From 5417d480444e99e2c02a13bc28675f68815fc942 Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Wed, 13 Apr 2022 22:47:17 +0200 Subject: [PATCH] Remove mostly-redundant test build component_test_CID_no_debug was added specifically to be a non-regression test for https://github.com/Mbed-TLS/mbedtls/issues/3998. Running compat.sh in the newly introduced config-ccm-psk-dtls1_2.h is also a non-regression test for that bug. Therefore component_test_CID_no_debug is redundant for its primary purpose. Of course every configuration is different, but the additional coverage from component_test_CID_no_debug is minimal, unlike config-ccm-psk-dtls1_2.h which is a plausible real-world configuration. In mbedtls-2.28, component_test_CID_no_debug was never added, and running the unit tests in that configuration does not trigger the #3998 bug, only compat.sh does. So, rather than backport component_test_CID_no_debug to 2.28.2, I am removing it from 3.2. Signed-off-by: Gilles Peskine --- tests/scripts/all.sh | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh index 0c2d9ddf6b..c31b3eec10 100755 --- a/tests/scripts/all.sh +++ b/tests/scripts/all.sh @@ -2239,18 +2239,6 @@ component_test_variable_ssl_in_out_buffer_len_CID () { tests/compat.sh } -component_test_CID_no_debug() { - msg "build: Connection ID enabled, debug disabled" - scripts/config.py unset MBEDTLS_DEBUG_C - scripts/config.py set MBEDTLS_SSL_DTLS_CONNECTION_ID - - CC=gcc cmake . - make - - msg "test: Connection ID enabled, debug disabled" - make test -} - component_test_ssl_alloc_buffer_and_mfl () { msg "build: default config with memory buffer allocator and MFL extension" scripts/config.py set MBEDTLS_MEMORY_BUFFER_ALLOC_C