lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-07-28 00:21:48 +03:00
Code Activity

Bignum Mod: pass endianness as a parameter

Browse Source 
The external representation before included more than just endianness
(like reading in Mongtomery curve scalars or converting hashes to
numbers in a standard compliant way).

These are higher level concepts and are out of scope for Bignum and for
the modulus structure.

Passing endianness as a parameter is a step towards removing it from the
modulus structure.

Signed-off-by: Janos Follath <janos.follath@arm.com>
This commit is contained in:
Janos Follath
2022-11-24 18:02:46 +00:00
parent d3eed33709
commit 3e3fc91c33
3 changed files with 54 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
library/bignum_mod.c
View File

@ -212,7 +212,8 @@ exit:
int mbedtls_mpi_mod_read( mbedtls_mpi_mod_residue *r,
const mbedtls_mpi_mod_modulus *m,
const unsigned char *buf,
size_t buflen )
size_t buflen,
mbedtls_mpi_mod_ext_rep ext_rep )
{
int ret = MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
@ -223,7 +224,7 @@ int mbedtls_mpi_mod_read( mbedtls_mpi_mod_residue *r,
r->limbs == 0 || m->limbs == 0 )
goto cleanup;
ret = mbedtls_mpi_mod_raw_read( r->p, m, buf, buflen );
ret = mbedtls_mpi_mod_raw_read( r->p, m, buf, buflen, ext_rep );
if( ret != 0 )
goto cleanup;
@ -240,7 +241,8 @@ cleanup:
int mbedtls_mpi_mod_write( const mbedtls_mpi_mod_residue *r,
const mbedtls_mpi_mod_modulus *m,
unsigned char *buf,
size_t buflen )
size_t buflen,
mbedtls_mpi_mod_ext_rep ext_rep )
{
int ret = MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
@ -254,7 +256,7 @@ int mbedtls_mpi_mod_write( const mbedtls_mpi_mod_residue *r,
if ( m->int_rep == MBEDTLS_MPI_MOD_REP_MONTGOMERY)
ret = mbedtls_mpi_mod_raw_from_mont_rep( r->p, m );
ret = mbedtls_mpi_mod_raw_write( r->p, m, buf, buflen );
ret = mbedtls_mpi_mod_raw_write( r->p, m, buf, buflen, ext_rep );
cleanup:
return ( ret );

28
library/bignum_mod.h
View File

@ -181,11 +181,12 @@ void mbedtls_mpi_mod_modulus_free( mbedtls_mpi_mod_modulus *m );
* and will be padded to m->limbs). The data will be automatically converted
* into the appropriate internal representation based on the value of `m->int_rep`.
*
* \param r The address of the residue related to \p m. It must have as
* many limbs as the modulus \p m.
* \param m The address of the modulus.
* \param buf The input buffer to import from.
* \param buflen The length in bytes of \p buf.
* \param r The address of the residue related to \p m. It must have as
* many limbs as the modulus \p m.
* \param m The address of the modulus.
* \param buf The input buffer to import from.
* \param buflen The length in bytes of \p buf.
* \param ext_rep The endianness of the number in the input buffer.
*
* \return \c 0 if successful.
* \return #MBEDTLS_ERR_MPI_BUFFER_TOO_SMALL if \p X isn't
@ -196,7 +197,8 @@ void mbedtls_mpi_mod_modulus_free( mbedtls_mpi_mod_modulus *m );
int mbedtls_mpi_mod_read( mbedtls_mpi_mod_residue *r,
const mbedtls_mpi_mod_modulus *m,
const unsigned char *buf,
size_t buflen );
size_t buflen,
mbedtls_mpi_mod_ext_rep ext_rep );
/** Write residue data onto a buffer using public representation data.
*
@ -206,11 +208,12 @@ int mbedtls_mpi_mod_read( mbedtls_mpi_mod_residue *r,
* converted from the appropriate internal representation based on the
* value of `m->int_rep field`.
*
* \param r The address of the residue related to \p m. It must have as
* many limbs as the modulus \p m.
* \param m The address of the modulus.
* \param buf The output buffer to export to.
* \param buflen The length in bytes of \p buf.
* \param r The address of the residue related to \p m. It must have as
* many limbs as the modulus \p m.
* \param m The address of the modulus.
* \param buf The output buffer to export to.
* \param buflen The length in bytes of \p buf.
* \param ext_rep The endianness in which the number should be written into the output buffer.
*
* \return \c 0 if successful.
* \return #MBEDTLS_ERR_MPI_BUFFER_TOO_SMALL if \p buf isn't
@ -221,7 +224,8 @@ int mbedtls_mpi_mod_read( mbedtls_mpi_mod_residue *r,
int mbedtls_mpi_mod_write( const mbedtls_mpi_mod_residue *r,
const mbedtls_mpi_mod_modulus *m,
unsigned char *buf,
size_t buflen );
size_t buflen,
mbedtls_mpi_mod_ext_rep ext_rep );
/* END MERGE SLOT 7 */
/* BEGIN MERGE SLOT 8 */