From 38a384d2ccddb9b2dce0fb7bb867269dee258dc3 Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Thu, 17 Jun 2021 14:35:25 +0200 Subject: [PATCH] Simplify is-zero check The loop exits early iff there is a nonzero limb, so i==0 means that all limbs are 0, whether the number of limbs is 0 or not. Signed-off-by: Gilles Peskine --- library/bignum.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/bignum.c b/library/bignum.c index 08ac4d6e94..3593e29ed7 100644 --- a/library/bignum.c +++ b/library/bignum.c @@ -1654,13 +1654,13 @@ int mbedtls_mpi_mul_mpi( mbedtls_mpi *X, const mbedtls_mpi *A, const mbedtls_mpi for( i = A->n; i > 0; i-- ) if( A->p[i - 1] != 0 ) break; - if( i == 0 && ( A->n == 0 || A->p[0] == 0 ) ) + if( i == 0 ) result_is_zero = 1; for( j = B->n; j > 0; j-- ) if( B->p[j - 1] != 0 ) break; - if( j == 0 && ( B->n == 0 || B->p[0] == 0 ) ) + if( j == 0 ) result_is_zero = 1; MBEDTLS_MPI_CHK( mbedtls_mpi_grow( X, i + j ) );