lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-06-13 19:21:32 +03:00
Code Activity

Bignum: clean up use of enums

Browse Source 
- Made use of enums in struct and function declaration
- All enums are handled by switch case now
- If the switch does nothing on default, omit the default case to make
  compiler warnings more powerful
- The two enums are now disjoint and the value 1 is skipped to make
  mistakes easier to detect

Signed-off-by: Janos Follath <janos.follath@arm.com>
This commit is contained in:
Janos Follath
2022-08-11 14:58:29 +01:00
parent 9dfb5621ff
commit 296ea66442
3 changed files with 55 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
library/bignum_mod_raw.c
View File

@ -48,13 +48,17 @@ int mbedtls_mpi_mod_raw_read( mbedtls_mpi_uint *X,
{
int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
if( m->ext_rep == MBEDTLS_MPI_MOD_EXT_REP_LE )
ret = mbedtls_mpi_core_read_le( X, m->n, buf, buflen );
else if( m->ext_rep == MBEDTLS_MPI_MOD_EXT_REP_BE )
ret = mbedtls_mpi_core_read_be( X, m->n, buf, buflen );
else
return( MBEDTLS_ERR_MPI_BAD_INPUT_DATA );
switch( m->ext_rep )
{
case MBEDTLS_MPI_MOD_EXT_REP_LE:
ret = mbedtls_mpi_core_read_le( X, m->n, buf, buflen );
break;
case MBEDTLS_MPI_MOD_EXT_REP_BE:
ret = mbedtls_mpi_core_read_be( X, m->n, buf, buflen );
break;
default:
return( MBEDTLS_ERR_MPI_BAD_INPUT_DATA );
}
if( ret != 0 )
goto cleanup;
@ -75,16 +79,15 @@ int mbedtls_mpi_mod_raw_write( mbedtls_mpi_uint *X,
unsigned char *buf,
size_t buflen )
{
if( m->ext_rep == MBEDTLS_MPI_MOD_EXT_REP_LE )
return mbedtls_mpi_core_write_le( X, m->n, buf, buflen );
else if( m->ext_rep == MBEDTLS_MPI_MOD_EXT_REP_BE )
return mbedtls_mpi_core_write_be( X, m->n, buf, buflen );
else
return( MBEDTLS_ERR_MPI_BAD_INPUT_DATA );
return( 0 );
switch( m->ext_rep )
{
case MBEDTLS_MPI_MOD_EXT_REP_LE:
return mbedtls_mpi_core_write_le( X, m->n, buf, buflen );
case MBEDTLS_MPI_MOD_EXT_REP_BE:
return mbedtls_mpi_core_write_be( X, m->n, buf, buflen );
default:
return( MBEDTLS_ERR_MPI_BAD_INPUT_DATA );
}
}
#endif /* MBEDTLS_BIGNUM_C */