lib/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2025-07-30 22:43:08 +03:00
Code Activity

Change psa_crypto_copy_output error code

Browse Source 
When we are copying output, it makes sense to return
PSA_ERROR_BUFFER_TOO_SMALL since the buffer we are copying to is a user
output buffer.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
This commit is contained in:
David Horstmann
2023-11-20 12:39:38 +00:00
parent 34c434a3ca
commit 232ab25bcd
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
library/psa_crypto.c
View File

@ -5558,7 +5558,7 @@ psa_status_t psa_crypto_copy_input(const uint8_t *input, size_t input_len,
* \param[out] output_len Length of the user-supplied output buffer. * \param[out] output_len Length of the user-supplied output buffer.
* \return #PSA_SUCCESS, if the buffer was successfully * \return #PSA_SUCCESS, if the buffer was successfully
* copied. * copied.
* \return #PSA_ERROR_CORRUPTION_DETECTED, if the * \return #PSA_ERROR_BUFFER_TOO_SMALL, if the
* user-supplied output buffer is too small to * user-supplied output buffer is too small to
* hold the contents of the local buffer. * hold the contents of the local buffer.
*/ */
@ -5567,7 +5567,7 @@ psa_status_t psa_crypto_copy_output(const uint8_t *output_copy, size_t output_co
uint8_t *output, size_t output_len) uint8_t *output, size_t output_len)
{ {
if (output_len < output_copy_len) { if (output_len < output_copy_len) {
return PSA_ERROR_CORRUPTION_DETECTED; return PSA_ERROR_BUFFER_TOO_SMALL;
} }
if (output_copy_len > 0) { if (output_copy_len > 0) {

2
tests/suites/test_suite_psa_crypto_memory.data
View File

@ -20,7 +20,7 @@ PSA output buffer copy: output buffer larger than required
copy_output:10:20:PSA_SUCCESS copy_output:10:20:PSA_SUCCESS
PSA output buffer copy: output buffer too small PSA output buffer copy: output buffer too small
copy_output:20:10:PSA_ERROR_CORRUPTION_DETECTED copy_output:20:10:PSA_ERROR_BUFFER_TOO_SMALL
PSA output buffer copy: zero-length source buffer PSA output buffer copy: zero-length source buffer
copy_output:0:10:PSA_SUCCESS copy_output:0:10:PSA_SUCCESS