From 03303d88fb1f8654a95ae7313eb237fc3ab611fd Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Wed, 11 Jun 2025 18:24:26 +0200 Subject: [PATCH] Don't mutate dst_size This lead to `dst_size` not having the intended value in subsequent code. Signed-off-by: Gilles Peskine --- tests/suites/test_suite_base64.function | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/suites/test_suite_base64.function b/tests/suites/test_suite_base64.function index 5d8ed9bf9f..3bd9932408 100644 --- a/tests/suites/test_suite_base64.function +++ b/tests/suites/test_suite_base64.function @@ -116,9 +116,8 @@ void mbedtls_base64_decode(char *src_string, char *dst_string, int result) if (result == 0 && dst_size != 0) { mbedtls_free(dst); dst = NULL; - dst_size -= 1; - TEST_CALLOC(dst, dst_size); - TEST_EQUAL(mbedtls_base64_decode(dst, dst_size, &len, + TEST_CALLOC(dst, dst_size - 1); + TEST_EQUAL(mbedtls_base64_decode(dst, dst_size - 1, &len, src, src_len), MBEDTLS_ERR_BASE64_BUFFER_TOO_SMALL); TEST_EQUAL(correct_dst_len, len);