lib/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2.git synced 2025-07-29 11:41:22 +03:00
Code Activity

Avoid creating an out-of-bounds pointer by rewriting a check

Browse Source 
Creating more than one-past-the-end pointers is undefined behaviour in C
and while this code is unlikely to be miscompiled, I discovered that an
out-of-bounds pointer is being created using UBSan on a CHERI-enabled
system.
This commit is contained in:
Alex Richardson
2022-12-01 12:53:15 +00:00
committed by Nick Wellnhofer
parent c62c0d82cc
commit c715ded086
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
HTMLparser.c
View File

@ -2314,7 +2314,7 @@ htmlEncodeEntities(unsigned char* out, int *outlen,
else
cp = ent->name;
len = strlen(cp);
if (out + 2 + len > outend)
if (outend - out < len + 2)
break;
*out++ = '&';
memcpy(out, cp, len);