lib/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2.git synced 2025-10-24 13:33:01 +03:00
Code Activity

Make xmlFreeNodeList non-recursive

Browse Source 
Avoid call stack overflow when freeing deeply nested documents.
This commit is contained in:
Nick Wellnhofer
2019-09-23 17:07:40 +02:00
parent 62150ed2ab
commit 0762c9b69b
1 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tree.c
View File

@@ -3664,7 +3664,9 @@ xmlNextElementSibling(xmlNodePtr node) {
void void
xmlFreeNodeList(xmlNodePtr cur) { xmlFreeNodeList(xmlNodePtr cur) {
xmlNodePtr next; xmlNodePtr next;
xmlNodePtr parent;
xmlDictPtr dict = NULL; xmlDictPtr dict = NULL;
size_t depth = 0;
if (cur == NULL) return; if (cur == NULL) return;
if (cur->type == XML_NAMESPACE_DECL) { if (cur->type == XML_NAMESPACE_DECL) {
@@ -3680,16 +3682,21 @@ xmlFreeNodeList(xmlNodePtr cur) {
return; return;
} }
if (cur->doc != NULL) dict = cur->doc->dict; if (cur->doc != NULL) dict = cur->doc->dict;
while (cur != NULL) { while (1) {
while ((cur->children != NULL) &&
(cur->type != XML_DTD_NODE) &&
(cur->type != XML_ENTITY_REF_NODE)) {
cur = cur->children;
depth += 1;
}
next = cur->next; next = cur->next;
parent = cur->parent;
if (cur->type != XML_DTD_NODE) { if (cur->type != XML_DTD_NODE) {
if ((__xmlRegisterCallbacks) && (xmlDeregisterNodeDefaultValue)) if ((__xmlRegisterCallbacks) && (xmlDeregisterNodeDefaultValue))
xmlDeregisterNodeDefaultValue(cur); xmlDeregisterNodeDefaultValue(cur);
if ((cur->children != NULL) &&
(cur->type != XML_ENTITY_REF_NODE))
xmlFreeNodeList(cur->children);
if (((cur->type == XML_ELEMENT_NODE) || if (((cur->type == XML_ELEMENT_NODE) ||
(cur->type == XML_XINCLUDE_START) || (cur->type == XML_XINCLUDE_START) ||
(cur->type == XML_XINCLUDE_END)) && (cur->type == XML_XINCLUDE_END)) &&
@@ -3720,7 +3727,16 @@ xmlFreeNodeList(xmlNodePtr cur) {
DICT_FREE(cur->name) DICT_FREE(cur->name)
xmlFree(cur); xmlFree(cur);
} }
cur = next;
if (next != NULL) {
cur = next;
} else {
if ((depth == 0) || (parent == NULL))
break;
depth -= 1;
cur = parent;
cur->children = NULL;
}
} }
} }