From c3d8976c03bbc260a7bb08bbcb409965953dd72a Mon Sep 17 00:00:00 2001 From: Joshua Rogers Date: Wed, 8 Oct 2025 01:18:00 +0800 Subject: [PATCH] Remove unused kex state variable `exchange_hash` (#1713) kex: completely remove unused exchange_hash it's unused. --- src/kex.c | 2 -- src/libssh2_priv.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/kex.c b/src/kex.c index 1a8f70b8..32774b05 100644 --- a/src/kex.c +++ b/src/kex.c @@ -642,7 +642,6 @@ static int diffie_hellman_sha_algo(LIBSSH2_SESSION *session, } } - exchange_state->exchange_hash = (void *)&exchange_hash_ctx; if(!_libssh2_sha_algo_ctx_init(sha_algo_value, exchange_hash_ctx)) { ret = _libssh2_error(session, LIBSSH2_ERROR_HASH_INIT, "Unable to initialize hash context"); @@ -1723,7 +1722,6 @@ do { \ rc = -1; \ break; \ } \ - exchange_state->exchange_hash = (void *)&ctx; \ hok = 1; \ if(session->local.banner) { \ _libssh2_htonu32(exchange_state->h_sig_comp, \ diff --git a/src/libssh2_priv.h b/src/libssh2_priv.h index 4bf911ad..b803d080 100644 --- a/src/libssh2_priv.h +++ b/src/libssh2_priv.h @@ -350,7 +350,6 @@ typedef struct kmdhgGPshakex_state_t size_t f_value_len; size_t k_value_len; size_t h_sig_len; - void *exchange_hash; packet_require_state_t req_state; libssh2_nonblocking_states burn_state; } kmdhgGPshakex_state_t;