From bd3dfed7e8f952b8d334c3f5d0d36c90f48c3edc Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Mon, 29 Sep 2008 13:42:41 +0000 Subject: [PATCH] Adhere to RFC4253 better and don't use dash in the banner string. Bug #2064371 --- NEWS | 2 ++ include/libssh2.h | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index aea7f9eb..62d0f4c1 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,8 @@ Version 0.19 ( ) ------------------------------- +- Bug #2064371 pointed out that the SSH2 banner may not use dash ('-'). + - Sean Peterson fixed a key re-exchange bug: http://daniel.haxx.se/projects/libssh2/mail/libssh2-devel-archive-2008-06/0002.shtml diff --git a/include/libssh2.h b/include/libssh2.h index 6fbe7bef..8f5ef6fd 100644 --- a/include/libssh2.h +++ b/include/libssh2.h @@ -1,4 +1,4 @@ -/* Copyright (c) 2004-2007, Sara Golemon +/* Copyright (c) 2004-2008, Sara Golemon * All rights reserved. * * Redistribution and use in source and binary forms, @@ -82,7 +82,11 @@ typedef unsigned long long libssh2_uint64_t; typedef long long libssh2_int64_t; #endif -#define LIBSSH2_VERSION "0.19.0-CVS" +/* We use underscore instead of dash when appending CVS in dev versions just + to make the BANNER define (used by src/session.c) be a valid SSH + banner. Release versions have no appended strings and may of coruse not + have dashes either. */ +#define LIBSSH2_VERSION "0.19.0_CVS" /* The numeric version number is also available "in parts" by using these defines: */