lib/libssh2
1
0
Fork 0
mirror of https://github.com/libssh2/libssh2.git synced 2025-07-31 00:03:08 +03:00
Code Activity

build: enable missing OpenSSF-recommended warnings, with fixes

Browse Source 
Ref:
https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.html
(2023-11-29)

Enable new warnings:

- replace `-Wno-sign-conversion` with `-Wsign-conversion`.

  Fix them in example, tests and wincng. There remain about 360 of these
  warnings in `src`. Add a TODO item for those and disable `-Werror` for
  this particular warning.

- enable `-Wformat=2` for clang (in both cmake and autotools).

- enable `__attribute__((format))` for `_libssh2_debug()`,
  `_libssh2_snprintf()` and in tests for `run_command()`.

  `LIBSSH2_PRINTF()` copied from `CURL_TEMP_PRINTF()` in curl.

- enable `-Wimplicit-fallthrough`.

- enable `-Wtrampolines`.

Fix them:

- src: replace obsolete fall-through-comments with
  `__attribute__((fallthrough))`.

- wincng: fix `-Wsign-conversion` warnings.

- tests: fix `-Wsign-conversion` warnings.

- example: fix `-Wsign-conversion` warnings.

- src: fix `-Wformat` issues in trace calls.

  Also, where necessary fix `int` and `unsigned char` casts to
  `unsigned int` and adjust printf format strings. These were not
  causing compiler warnings.

  Cast large types to `long` to avoid dealing with printf masks for
  `size_t` and other C99 types. Existing code often used `int` for this.
  I'll update them to `long` in an upcoming commit.

- tests: fix `-Wformat` warning.

- silence `-Wformat-nonliteral` warnings.

- mbedtls: silence `-Wsign-conversion`/`-Warith-conversion`
  in external header.

Closes #1257
This commit is contained in:
Viktor Szakats
2023-11-30 23:35:11 +00:00
parent e0a0466490
commit afa6b86560
43 changed files with 299 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
example/sftp.c
View File

@ -55,11 +55,11 @@ static void kbd_callback(const char *name, int name_len,
fprintf(stderr, "Performing keyboard-interactive authentication.\n");
fprintf(stderr, "Authentication name: '");
fwrite(name, 1, name_len, stderr);
fwrite(name, 1, (size_t)name_len, stderr);
fprintf(stderr, "'\n");
fprintf(stderr, "Authentication instruction: '");
fwrite(instruction, 1, instruction_len, stderr);
fwrite(instruction, 1, (size_t)instruction_len, stderr);
fprintf(stderr, "'\n");
fprintf(stderr, "Number of prompts: %d\n\n", num_prompts);
@ -275,7 +275,7 @@ int main(int argc, char *argv[])
fprintf(stderr, "libssh2_sftp_read().\n");
nread = libssh2_sftp_read(sftp_handle, mem, sizeof(mem));
if(nread > 0) {
write(1, mem, nread);
write(1, mem, (size_t)nread);
}
else {
break;