lib/libssh2
1
0
Fork 0
mirror of https://github.com/libssh2/libssh2.git synced 2025-08-08 19:02:07 +03:00
Code Activity

ossfuzz: fix picky compiler warnings, make it pass checksrc

Browse Source 
- fix compiler warnings.
- make it pass `checksrc`.
- fix shell `set -u` errors.
  Follow-up to 5012442850 #901
- REUSE: tidy up ossfuzz files.

Cherry-picked from #1484
Closes #1526
This commit is contained in:
Viktor Szakats
2024-11-24 18:05:34 +01:00
parent a3aa6b4ca8
commit 96cbe61896
6 changed files with 119 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

122
tests/ossfuzz/ssh2_client_fuzzer.cc
View File

@@ -14,84 +14,84 @@
#include "testinput.h"
#define FUZZ_ASSERT(COND) \
if(!(COND)) \
{ \
fprintf(stderr, "Assertion failed: " #COND "\n%s", \
strerror(errno)); \
assert((COND)); \
}
do { \
if(!(COND)) \
{ \
fprintf(stderr, "Assertion failed: " #COND "\n%s", \
strerror(errno)); \
assert((COND)); \
} \
} while(0)
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
{
int socket_fds[2] = {-1, -1};
ssize_t written;
int rc;
LIBSSH2_SESSION *session = NULL;
int handshake_completed = 0;
int socket_fds[2] = {-1, -1};
ssize_t written;
int rc;
LIBSSH2_SESSION *session = NULL;
int handshake_completed = 0;
rc = libssh2_init(0);
rc = libssh2_init(0);
if(rc) {
fprintf(stderr, "libssh2 initialization failed (%d)\n", rc);
goto EXIT_LABEL;
}
if(rc) {
fprintf(stderr, "libssh2 initialization failed (%d)\n", rc);
goto EXIT_LABEL;
}
// Create a socket pair so data can be sent in.
rc = socketpair(AF_UNIX, SOCK_STREAM, 0, socket_fds);
FUZZ_ASSERT(rc == 0);
/* Create a socket pair so data can be sent in. */
rc = socketpair(AF_UNIX, SOCK_STREAM, 0, socket_fds);
FUZZ_ASSERT(rc == 0);
written = send(socket_fds[1], data, size, 0);
written = send(socket_fds[1], data, size, 0);
if(written != size)
{
// Handle whatever error case we're in.
fprintf(stderr, "send() of %zu bytes returned %zu (%d)\n",
size,
written,
errno);
goto EXIT_LABEL;
}
if(written != (ssize_t)size) {
/* Handle whatever error case we're in. */
fprintf(stderr, "send() of %zu bytes returned %zu (%d)\n",
size,
written,
errno);
goto EXIT_LABEL;
}
rc = shutdown(socket_fds[1], SHUT_WR);
if(rc)
{
fprintf(stderr, "socket shutdown failed (%d)\n", rc);
goto EXIT_LABEL;
}
rc = shutdown(socket_fds[1], SHUT_WR);
if(rc) {
fprintf(stderr, "socket shutdown failed (%d)\n", rc);
goto EXIT_LABEL;
}
// Create a session and start the handshake using the fuzz data passed in.
session = libssh2_session_init();
if(session) {
libssh2_session_set_blocking(session, 1);
}
else {
goto EXIT_LABEL;
}
/* Create a session and start the handshake using the fuzz data
passed in. */
session = libssh2_session_init();
if(session) {
libssh2_session_set_blocking(session, 1);
}
else {
goto EXIT_LABEL;
}
if(libssh2_session_handshake(session, socket_fds[0])) {
goto EXIT_LABEL;
}
if(libssh2_session_handshake(session, socket_fds[0])) {
goto EXIT_LABEL;
}
// If we get here the handshake actually completed.
handshake_completed = 1;
/* If we get here the handshake actually completed. */
handshake_completed = 1;
EXIT_LABEL:
if(session)
{
if(handshake_completed)
{
libssh2_session_disconnect(session,
"Normal Shutdown, Thank you for playing");
if(session) {
if(handshake_completed) {
libssh2_session_disconnect(session,
"Normal Shutdown, "
"Thank you for playing");
}
libssh2_session_free(session);
}
libssh2_session_free(session);
}
libssh2_exit();
libssh2_exit();
close(socket_fds[0]);
close(socket_fds[1]);
close(socket_fds[0]);
close(socket_fds[1]);
return 0;
return 0;
}