lib/libssh2
1
0
Fork 0
mirror of https://github.com/libssh2/libssh2.git synced 2025-11-21 14:00:51 +03:00
Code Activity

cmake: unset forced CMAKE_C_STANDARD 90 (#822)

Browse Source 
Added in cf80f2f4b5 (on 2016-08-14),
with the title "Basic dockerised test suite".

It's not clear why a C standard was explicitly set, but a side-effect
of this is that CMake-built binaries diverged from ones built with
autotools or GNU Make (using the same compiler and configuration).

Another issue is that this may introduce ABI incompatibility with
binaries built with a different C standard flag, e.g. the C compiler
default or one used for other components of a final app.

Seems unlikely, but if our tests require this option, we should set it
for the CI builds only?
This commit is contained in:
Viktor Szakats
2023-03-09 11:48:21 +01:00
committed by GitHub
parent 99c1333ba7
commit 8795d9c817
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@@ -44,8 +44,6 @@ project(libssh2 C)
set(PROJECT_URL "https://www.libssh2.org/") set(PROJECT_URL "https://www.libssh2.org/")
set(PROJECT_DESCRIPTION "The SSH library") set(PROJECT_DESCRIPTION "The SSH library")
set(CMAKE_C_STANDARD 90)
option(BUILD_SHARED_LIBS "Build Shared Libraries" OFF) option(BUILD_SHARED_LIBS "Build Shared Libraries" OFF)
# Parse version # Parse version