lib/libssh2
1
0
Fork 0
mirror of https://github.com/libssh2/libssh2.git synced 2025-11-20 02:42:09 +03:00
Code Activity

kex: fix overlapping memcpy() to memmove()

Browse Source 
Noticed this when libasan started kicking out errors when sending in
MACs preferences that were not supported yet.

Reported-by: fourierules on github
Fixes #611
Closes #1000
This commit is contained in:
Viktor Szakats
2023-04-20 22:55:49 +00:00
parent 4e256cf18a
commit 437af7e88f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/kex.c
View File

@@ -4027,7 +4027,7 @@ libssh2_session_method_pref(LIBSSH2_SESSION * session, int method_type,
if(!kex_get_method_by_name(s, method_len, mlist)) { if(!kex_get_method_by_name(s, method_len, mlist)) {
/* Strip out unsupported method */ /* Strip out unsupported method */
if(p) { if(p) {
memcpy(s, p + 1, strlen(s) - method_len); memmove(s, p + 1, strlen(s) - method_len);
} }
else { else {
if(s > newprefs) { if(s > newprefs) {