From 31ec5a8b55cc90efb0bd1bb2be621e416f1444ef Mon Sep 17 00:00:00 2001 From: Joshua Rogers Date: Fri, 10 Oct 2025 01:18:53 +0800 Subject: [PATCH] packet: authagent_open: fix failure packet length (#1701) Compute packet_len using strlen(AuthAgentUnavail) (not X11FwdUnAvil). The mismatch could send 1 uninitialized byte on the wire. Credit: Joshua Rogers --- src/packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/packet.c b/src/packet.c index 9e967191..34940ec3 100644 --- a/src/packet.c +++ b/src/packet.c @@ -464,7 +464,7 @@ packet_authagent_open(LIBSSH2_SESSION * session, { uint32_t failure_code = SSH_OPEN_CONNECT_FAILED; /* 17 = packet_type(1) + channel(4) + reason(4) + descr(4) + lang(4) */ - size_t packet_len = 17 + strlen(X11FwdUnAvil); + size_t packet_len = 17 + strlen(AuthAgentUnavail); unsigned char *p; LIBSSH2_CHANNEL *channel = authagent_state->channel; int rc;