lib/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-08-08 19:02:06 +03:00
Code Activity

pki: Ensure sig_blob isn't used uninitialized.

Browse Source
This commit is contained in:
Andreas Schneider
2011-08-22 08:04:22 +02:00
parent 859ed8583c
commit a86ac461fd
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/pki_crypto.c
View File

@@ -523,7 +523,7 @@ static ssh_string _RSA_do_sign(const unsigned char *payload,
ssh_string pki_signature_to_blob(const ssh_signature sig) ssh_string pki_signature_to_blob(const ssh_signature sig)
{ {
char buffer[40] = {0}; char buffer[40] = {0};
ssh_string sig_blob; ssh_string sig_blob = NULL;
ssh_string r; ssh_string r;
ssh_string s; ssh_string s;
@@ -560,7 +560,8 @@ ssh_string pki_signature_to_blob(const ssh_signature sig)
sig_blob = string_copy(sig->rsa_sig); sig_blob = string_copy(sig->rsa_sig);
case SSH_KEYTYPE_ECDSA: case SSH_KEYTYPE_ECDSA:
case SSH_KEYTYPE_UNKNOWN: case SSH_KEYTYPE_UNKNOWN:
break; ssh_pki_log("Unknown signature key type: %d", sig->type);
return NULL;
} }
return sig_blob; return sig_blob;

4
src/pki_gcrypt.c
View File

@@ -1173,7 +1173,7 @@ ssh_string pki_signature_to_blob(const ssh_signature sig)
const char *s = NULL; const char *s = NULL;
gcry_sexp_t sexp; gcry_sexp_t sexp;
size_t size = 0; size_t size = 0;
ssh_string sig_blob; ssh_string sig_blob = NULL;
switch(sig->type) { switch(sig->type) {
case SSH_KEYTYPE_DSS: case SSH_KEYTYPE_DSS:
@@ -1224,6 +1224,8 @@ ssh_string pki_signature_to_blob(const ssh_signature sig)
break; break;
case SSH_KEYTYPE_ECDSA: case SSH_KEYTYPE_ECDSA:
case SSH_KEYTYPE_UNKNOWN: case SSH_KEYTYPE_UNKNOWN:
ssh_pki_log("Unknown signature key type: %d", sig->type);
return NULL;
break; break;
} }