From a2bb9b5d0c79508e21cde4be88c5749d11b705eb Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Wed, 16 Apr 2025 16:39:17 +0200 Subject: [PATCH] test: Fix potential leak of fds on error Signed-off-by: Jakub Jelen Reviewed-by: Norbert Pocs (cherry picked from commit f0b9db586b1404ef6a31327348eb85b1de6240ad) --- tests/server/test_server/test_server.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/server/test_server/test_server.c b/tests/server/test_server/test_server.c index b77ee7a1..a75f6f8b 100644 --- a/tests/server/test_server/test_server.c +++ b/tests/server/test_server/test_server.c @@ -125,12 +125,14 @@ int run_server(struct server_state_st *state) if (fd == -1) { fprintf(stderr, "dup2 of log file to stderr failed: %s\n", strerror(errno)); + fclose(f); goto out; } fd = dup2(fileno(f), STDOUT_FILENO); if (fd == -1) { fprintf(stderr, "dup2 of log file to stdout failed: %s\n", strerror(errno)); + fclose(f); goto out; } fclose(f);