From 9709a466d7a49766b4b68b4f8b5f9bdcd72f1e1c Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Wed, 28 Jun 2023 10:17:25 +0200 Subject: [PATCH] sftpserver: Set OOM only if allocation fails Signed-off-by: Jakub Jelen Reviewed-by: Norbert Pocs --- src/sftpserver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/sftpserver.c b/src/sftpserver.c index 1e547528..e44032ba 100644 --- a/src/sftpserver.c +++ b/src/sftpserver.c @@ -73,6 +73,7 @@ sftp_make_client_message(sftp_session sftp, sftp_packet packet) /* take a copy of the whole packet */ msg->complete_message = ssh_buffer_new(); if (msg->complete_message == NULL) { + ssh_set_error_oom(session); goto error; } @@ -233,14 +234,12 @@ sftp_make_client_message(sftp_session sftp, sftp_packet packet) default: ssh_set_error(sftp->session, SSH_FATAL, "Received unhandled sftp message %d", msg->type); - sftp_client_message_free(msg); - return NULL; + goto error; } return msg; error: - ssh_set_error_oom(session); sftp_client_message_free(msg); return NULL; }