lib/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-12-09 15:41:10 +03:00
Code Activity

sftp: Check return value of ssh_buffer_add_data

Browse Source 
CID 1513156

Thanks coverity

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Sahana Prasad <sahana@redhat.com>
This commit is contained in:
Jakub Jelen
2023-06-20 15:09:32 +02:00
parent 4b8db203b0
commit 812ba3b717
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/sftp.c
View File

@@ -372,7 +372,7 @@ sftp_decode_channel_data_to_packet(sftp_session sftp, void *data, uint32_t len)
int nread; int nread;
int payload_len; int payload_len;
unsigned int data_offset; unsigned int data_offset;
int to_read; int to_read, rc;
if (packet->sftp == NULL) { if (packet->sftp == NULL) {
packet->sftp = sftp; packet->sftp = sftp;
@@ -393,9 +393,12 @@ sftp_decode_channel_data_to_packet(sftp_session sftp, void *data, uint32_t len)
} }
to_read = payload_len - sizeof(uint8_t); to_read = payload_len - sizeof(uint8_t);
ssh_buffer_add_data(packet->payload, rc = ssh_buffer_add_data(packet->payload,
(void*)((uint8_t *)data + data_offset), (void*)((uint8_t *)data + data_offset),
to_read); to_read);
if (rc != 0) {
return SSH_ERROR;
}
nread = ssh_buffer_get_len(packet->payload); nread = ssh_buffer_get_len(packet->payload);
/* We should check if we copied the whole data */ /* We should check if we copied the whole data */