lib/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2025-07-28 01:41:48 +03:00
Code Activity

tests: Properly initilize library in threads tests

Browse Source 
This was already done in the torture_threads_pki.

Without the explicit initialization, we can observe random
failures tests (at least of the torture_threads_crypto) from
various threads.

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Jakub Jelen
2018-08-31 11:31:08 +02:00
committed by Andreas Schneider
parent b4c8bd9fe4
commit 6b10bbea2f
3 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unittests/torture_threads_buffer.c
View File

@ -589,8 +589,14 @@ int torture_run_tests(void)
cmocka_unit_test(torture_mixed), cmocka_unit_test(torture_mixed),
}; };
/*
* If the library is statically linked, ssh_init() is not called
* automatically
*/
ssh_init();
torture_filter_tests(tests); torture_filter_tests(tests);
rc = cmocka_run_group_tests(tests, NULL, NULL); rc = cmocka_run_group_tests(tests, NULL, NULL);
ssh_finalize();
return rc; return rc;
} }

6
tests/unittests/torture_threads_crypto.c
View File

@ -175,7 +175,13 @@ int torture_run_tests(void)
cmocka_unit_test(torture_crypto_aes256_cbc), cmocka_unit_test(torture_crypto_aes256_cbc),
}; };
/*
* If the library is statically linked, ssh_init() is not called
* automatically
*/
ssh_init();
rc = cmocka_run_group_tests(tests, NULL, NULL); rc = cmocka_run_group_tests(tests, NULL, NULL);
ssh_finalize();
return rc; return rc;
} }

6
tests/unittests/torture_threads_init.c
View File

@ -88,8 +88,14 @@ int torture_run_tests(void)
cmocka_unit_test(torture_ssh_init), cmocka_unit_test(torture_ssh_init),
}; };
/*
* If the library is statically linked, ssh_init() is not called
* automatically
*/
ssh_init();
torture_filter_tests(tests); torture_filter_tests(tests);
rc = cmocka_run_group_tests(tests, NULL, NULL); rc = cmocka_run_group_tests(tests, NULL, NULL);
ssh_finalize();
return rc; return rc;
} }